Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
https://wiki.archlinux.org/title/Bug_reporting_guidelines
Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.
REPEAT: Do NOT report bugs for outdated packages!
FS#13383 - [mldonkey] Add option to pass additional arguments to mlnet
Attached to Project:
Community Packages
Opened by Denis Yantarev (denn) - Thursday, 19 February 2009, 19:23 GMT
Last edited by Corrado Primier (bardo) - Tuesday, 14 July 2009, 15:29 GMT
Opened by Denis Yantarev (denn) - Thursday, 19 February 2009, 19:23 GMT
Last edited by Corrado Primier (bardo) - Tuesday, 14 July 2009, 15:29 GMT
|
DetailsIt would be nice to be able to pass additional command line options to mlnet daemon in rc script. To do so we can add PARAMS variable to conf.d/mldonkey and pass it to mlnet at startup. Proposed patch is attached.
|
This task depends upon
Closed by Corrado Primier (bardo)
Tuesday, 14 July 2009, 15:29 GMT
Reason for closing: Fixed
Additional comments about closing: The only remaining issue of log files has been solved in mldonkey-3.0.0-3, that I just uploaded for x86_64 and will upload for i686 in a short while. I found and added the '-log_to_syslog' option to /etc/rc.d/mldonkey, now they are managed by syslog-ng.
Tuesday, 14 July 2009, 15:29 GMT
Reason for closing: Fixed
Additional comments about closing: The only remaining issue of log files has been solved in mldonkey-3.0.0-3, that I just uploaded for x86_64 and will upload for i686 in a short while. I found and added the '-log_to_syslog' option to /etc/rc.d/mldonkey, now they are managed by syslog-ng.
mldonkey.patch
No need to open another task, I can manage everything from here. Just be sure to send in other great ideas before I close this one, if they come to your mind ;-)
BTW, the way I get the user's home directory is fugly and slow:
$(su $MLDUSER -s /bin/sh -c 'echo $HOME')
I think I'll change it in the more elegant and twenty-times-faster:
$(getent passwd $MLDUSER | cut -d: -f6)
Another idea in this vein would be to move log file to /var/log. :)
The whole PIDFILE thing had to be implemented a bit differently, and logs withing /var/log can't be done at all, both for the same reason: mldonkey drops privileges, so it can't write to these directories. The pid file can happily go to /var/lock (this is the reason it exists, by the way), for the log file there's nothing you can do.
Also, I chose to allow the user to set PIDDIR instead of PIDFILE since this is the parameter mldonkey takes, the filename is always 'mlnet.pid', so it made no sense to specify a filename which would have been treated like a directory anyway, and with funny effects =)
After all, if you think about it, mldonkey doesn't supply a system daemon, we "implement" it through the rc.d script, but there's no support on the program's side.