FS#13122 - Comments are parsed during upload

Attached to Project: AUR web interface
Opened by Phillip Smith (fukawi2) - Wednesday, 04 February 2009, 22:21 GMT
Last edited by Loui Chang (louipc) - Tuesday, 29 September 2009, 00:13 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To Loui Chang (louipc)
Architecture All
Severity Medium
Priority Normal
Reported Version 1.5.6
Due in Version 1.6.0
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

It seems that comments are parsed during uploading a PKGBUILD tarball.

A specific case where this causes problems is where the comments have an opening round-bracket "(" without closing round-bracket ")".

Eg, if the top of the PKGBUILD has this line (note the missing bracket at the end of the e-mail address)
# Contributor: Phillip Smith (fukawi2@my.email.address.com

Then the following error is given after upload:
Missing url variable in PKGBUILD.

System should at minimum give a sensical error, or preferably ignore the comment lines entirely.
This task depends upon

Closed by  Loui Chang (louipc)
Tuesday, 29 September 2009, 00:13 GMT
Reason for closing:  Fixed
Comment by Phillip Smith (fukawi2) - Wednesday, 04 February 2009, 22:21 GMT
Refer forum thread http://bbs.archlinux.org/viewtopic.php?pid=493339
Comment by Loui Chang (louipc) - Friday, 06 February 2009, 20:27 GMT
Hah you're just trying to break the AUR aren't you?
Comment by Gergely (imrehg) - Friday, 13 February 2009, 17:07 GMT
Patch sent to AUR dev list.
Comment by Arto Puranen (Purch) - Friday, 29 May 2009, 13:04 GMT
  • Field changed: Percent Complete (100% → 0%)
A commented source line in pkgbuild gave error in AUR upload. "Missing the build function" http://pastebin.com/m38a231a1
Comment by Gergely (imrehg) - Saturday, 30 May 2009, 06:43 GMT
Patch sent to AUR dev list (once again)

The comment removal wasn't early enough, which caused problem with the bracket matching. Not sure why was it like that, the previous form wouldn't have solved the original bug. This patched form should do the trick (as much as I have checked with commented PKGBUILDs.)
Comment by Loui Chang (louipc) - Thursday, 18 June 2009, 06:11 GMT
Patch is in git. Thanks Greg.

Loading...