FS#12344 - If dotglob set in PKGBUILD, .PKGINFO is included twice in resulting package file

Attached to Project: Pacman
Opened by Thayer Williams (thayer) - Thursday, 04 December 2008, 19:19 GMT
Last edited by Dan McGee (toofishes) - Saturday, 03 January 2009, 05:36 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Dan McGee (toofishes)
Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version 3.2.1
Due in Version 3.2.2
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:

If 'shopt -s dotglob' is set within a PKGBUILD, a .PKGINFO is included twice in the resulting package file. The db scripts will then read it twice and assume the package is built for the wrong architecture (i686 i686).

The solution is to reset the shell option at the end of build():

shopt -u dotglob

An example can be found in the gtk2-themes-collection package.
This task depends upon

Closed by  Dan McGee (toofishes)
Saturday, 03 January 2009, 05:36 GMT
Reason for closing:  Fixed
Additional comments about closing:  Commit 59776ef3
Comment by Dan McGee (toofishes) - Thursday, 04 December 2008, 20:24 GMT
We should probably save and restore shopts before/after the build() function, if that is possible?
Comment by Dan McGee (toofishes) - Thursday, 04 December 2008, 20:26 GMT
1. save the output of $(shopt -p)
2. run build()
3. eval the previously stored output

Should be low-hanging fruit here if someone wants to make a patch for this.
Comment by Dan McGee (toofishes) - Friday, 05 December 2008, 02:50 GMT
Patch sent to the ML: http://archlinux.org/pipermail/pacman-dev/2008-December/007730.html

Loading...