Pacman

Historical bug tracker for the Pacman package manager.

The pacman bug tracker has moved to gitlab:
https://gitlab.archlinux.org/pacman/pacman/-/issues

This tracker remains open for interaction with historical bugs during the transition period. Any new bugs reports will be closed without further action.
Tasklist

FS#11946 - makepkg breaks with bash 3.1.17

Attached to Project: Pacman
Opened by Aman Gupta (tmm1) - Friday, 31 October 2008, 07:26 GMT
Last edited by Dan McGee (toofishes) - Saturday, 01 November 2008, 00:58 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Xavier (shining)
Dan McGee (toofishes)
Architecture All
Severity Medium
Priority Normal
Reported Version git
Due in Version 3.2.2
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:

makepkg does not work with bash 3.1.17. Version 3.2.17 works fine. The following patch fixes the issue and works on both versions:

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 266e214..0813855 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -307,12 +307,12 @@ download_file() {

# replace %o by the temporary dlfile if it exists
if echo "$dlcmd" | grep -q "%o" ; then
- dlcmd=${dlcmd//%o/$file.part}
+ dlcmd=${dlcmd//\%o/$file.part}
dlfile="$file.part"
fi
# add the url, either in place of %u or at the end
if echo "$dlcmd" | grep -q "%u" ; then
- dlcmd=${dlcmd//%u/$url}
+ dlcmd=${dlcmd//\%u/$url}
else
dlcmd="$dlcmd $url"
fi

This task depends upon

Closed by  Dan McGee (toofishes)
Saturday, 01 November 2008, 00:58 GMT
Reason for closing:  Fixed
Additional comments about closing:  http://projects.archlinux.org/?p=pacman. git;a=commitdiff;h=2890114600baefb6cb1dd e513ca3107258b64c92
Comment by Dan McGee (toofishes) - Friday, 31 October 2008, 13:11 GMT
Interesting. If this really works in both, then it seems fine to me.

Xavier, any comments? This was your code change at one point if I remember right (and according to git-annotate).
Comment by Xavier (shining) - Friday, 31 October 2008, 14:31 GMT
I didn't test anything and was not aware about this issue, but I felt like trusting the reporter on this one, because the proposed change seems coherent and safe enough.
Comment by Allan McRae (Allan) - Friday, 31 October 2008, 14:43 GMT
I can confirm the fix does not break anything under bash 3.2 and makes the substitution work under bash 3.0
Comment by Dan McGee (toofishes) - Saturday, 01 November 2008, 00:00 GMT
Pushed this patch to my maint branch.

Loading...