Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#11830 - Rocksndiamonds uses unnecessary wrapper script

Attached to Project: Community Packages
Opened by Tomi Belan (Tomi) - Tuesday, 21 October 2008, 17:21 GMT
Last edited by Sergej Pupykin (sergej) - Thursday, 23 October 2008, 10:48 GMT
Task Type Bug Report
Category
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
rocksndiamonds-3.2.4-1 in community uses the following wrapper script to run rocksndiamonds:

#!/bin/sh
exec /usr/bin/rocksndiamonds-bin -b /usr/share/rocksndiamonds

This works (although not very well, see below), but it's an unnecessary and non-KISS workaround - the rocksndiamonds binary can use a pre-configured data path. 'make' it with:
make RO_GAME_DIR=/usr/share/rocksndiamonds RW_GAME_DIR=/usr/share/rocksndiamonds || return 1

The wrapper script itself has a bug too: it doesn't pass any program arguments to rocksndiamonds-bin itself. (See rocksndiamonds-bin --help for a list of arguments it supports. For example, this makes network multiplayer impossible.) If the script was to stay, it should at least have "$@" (including the quotes) appended at the end.
This task depends upon

Closed by  Sergej Pupykin (sergej)
Thursday, 23 October 2008, 10:48 GMT
Reason for closing:  Fixed
Additional comments about closing:  rocksndiamonds-3.2.4-2-i686.pkg.tar.gz

Loading...