FS#11611 - 'mknod: File exists - /dev/mapper/control' When using encrypt+lvm setup

Attached to Project: Arch Linux
Opened by Dieter Plaetinck (Dieter_be) - Sunday, 28 September 2008, 14:42 GMT
Last edited by Aaron Griffin (phrakture) - Thursday, 05 February 2009, 19:06 GMT
Task Type Bug Report
Category System
Status Closed
Assigned To Tobias Powalowski (tpowa)
Eric Belanger (Snowman)
Aaron Griffin (phrakture)
Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version None
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Hi, I'm not sure it's really a bug but I'm reporting just to be sure (Romashka asked so nicely ;-)

I'm using a setup that has filesystems on top of lvm on top of dm_crypt on top of a physical partition.
I get this output in initramfs:

:: Running Hook [encrypt]
device-mapper: uevent: version 1.0.3
device-mapper: ioctl: 4.13.0-ioctl (2007-10-18) initialised: dm-devel@redhat.com

A password is required to access the root volume:
Enter LUKS passphrase:
key slot 0 unlocked.
:: Running hook [lvm2]
mknod: File exists - /dev/mapper/control <---------------------------------------------------
Scanning logical volumes...
Reading al physical volumes. This may take a while...
found volume group "lvmpool" using metadata type lvm2
Activating logical volumes...
4 logical volume(s) in volume group "lvmpool" now active
:: Running Hook [filesystems]
:: Loading root filesystem module...lvm2
Waiting for devices to settle...done.
:: Initramfs completed - control passing to kinit



If you want I can rebuild the initramfs things to test with only encrypt and only lvm2 to see if it still occurs, but I never did this manually (yet) so you'll have to explain :)
OTOH It's probably much easier to just check the code in the hook files. /lib/initcpio/hooks/{lvm2,encrypt}
If you understand the code you probably see the problem immediately.
I think it's this: encypt only does mk_nod if [ ! -c "/dev/mapper/control" ], the lvm2 hook always does mk_nod without checking
This task depends upon

Closed by  Aaron Griffin (phrakture)
Thursday, 05 February 2009, 19:06 GMT
Reason for closing:  Fixed
Comment by Thomas Bächler (brain0) - Sunday, 28 September 2008, 15:21 GMT
This has been there since day 1. I never cared to correct it, as it doesn't cause any problems. We could add that [ ! -c /dev/mapper/control ] check to lvm2.
Comment by Aaron Griffin (phrakture) - Thursday, 20 November 2008, 20:10 GMT
Committed a conditional check to the hook in svn trunk. Close this when a new lvm2 is released, I guess
Comment by Eric Belanger (Snowman) - Thursday, 20 November 2008, 20:18 GMT
There is already a lvm2 package in testing. Do you want me to release a new one with this fix included?
Comment by Aaron Griffin (phrakture) - Thursday, 20 November 2008, 20:25 GMT
It's not super critical. Up to you. I just like to do small things to trunk as soon as I can just to get the fix out there. I wouldn't rush though.
Comment by Eric Belanger (Snowman) - Thursday, 20 November 2008, 20:33 GMT
I'll wait then.
Comment by Dieter Plaetinck (Dieter_be) - Thursday, 20 November 2008, 20:35 GMT
Thanks for the fix Aaron, it's not critical at all indeed, just a visual thingie.
Comment by Eric Belanger (Snowman) - Thursday, 05 February 2009, 05:01 GMT
The lvm2 currently in testing uses the fixed hook. It would be nice if you could test and confirm if it fixes this bug.
Comment by Dieter Plaetinck (Dieter_be) - Thursday, 05 February 2009, 19:05 GMT
Yep. the "error" message is gone.

Loading...