AUR web interface

Tasklist

FS#11132 - AUR fails to parse multiline source array

Attached to Project: AUR web interface
Opened by Arvid Norlander (AnMaster) - Wednesday, 06 August 2008, 13:46 GMT
Last edited by Callan Barrett (wizzomafizzo) - Thursday, 25 December 2008, 12:47 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To Loui Chang (louipc)
Callan Barrett (wizzomafizzo)
Architecture All
Severity Low
Priority Normal
Reported Version 1.5.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

AUR misses out on one of the files in the source array in http://aur.archlinux.org/packages.php?ID=18937.

Someone suggested that AUR needs ending \ in the source array to correctly parse it, this is wrong, bash doesn't need it, nor does the md5sum array generated by makepkg -g use it, so it is illogical in as well to require it in the source array.

But I'm not sure that is the issue as AUR finds one of the files in the source array. Yet the code is perfectly valid bash code and makepkg has no issues with it, which leads the the conclusion that there is some issue in AUR.

I have attached the PKGBUILD in question in case I update the PKGBUILD for C-INTERCAL in AUR.
   PKGBUILD (1 KiB)
Closed by  Callan Barrett (wizzomafizzo)
Thursday, 25 December 2008, 12:47 GMT
Reason for closing:  Fixed
Comment by Evangelos Foutras (foutrelis) - Monday, 24 November 2008, 00:39 GMT
The problem seems to lie in the way "web/html/pkgsubmit.php" handles parentheses when it reads the PKGBUILD and concatenates contiguous lines. It decides whether to append the next line onto the current one based on the number of open parentheses. However, it only looks at the current line, ignoring parentheses opened in previous lines.

I've attached a patch for review.
   0001-Fixed-FS-11132.patch (1.2 KiB)
Comment by Loui Chang (louipc) - Saturday, 20 December 2008, 18:40 GMT
Patch is in git.

Loading...