FS#10309 - id3lib headers not gcc-4.3 compliant

Attached to Project: Arch Linux
Opened by Sébastien (sebcactus) - Monday, 28 April 2008, 19:08 GMT
Last edited by Eric Belanger (Snowman) - Monday, 26 May 2008, 00:10 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Andreas Radke (AndyRTR)
Architecture All
Severity Low
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
id3lib_strings.h is missing <cstring>, there may be other problems.
I think id3lib should be recompiled with gcc-4.3.
I tried to compile it with ABS and I found a few mistakes.

Additional info:
* package version(s): id3lib-3.8.3

* config and/or log files etc.
In file included from /usr/include/id3/utils.h:37,
from /usr/include/id3/tag.h:34,
from .sconf_temp/conftest_39.cpp:3:
/usr/include/id3/id3lib_strings.h: In static member function 'static unsigned char* std::char_traits<unsigned char>::move(unsigned char*, const unsigned char*, size_t)':
/usr/include/id3/id3lib_strings.h:87: error: 'memmove' was not declared in this scope
/usr/include/id3/id3lib_strings.h: In static member function 'static unsigned char* std::char_traits<unsigned char>::copy(unsigned char*, const unsigned char*, size_t)':
/usr/include/id3/id3lib_strings.h:91: error: 'memcpy' was not declared in this scope


Steps to reproduce:
include id3lib_strings.h and use gcc-4.3 to compile.

Solution:
* In configure:
- should check iomanip, instead of iomanip.h

* In example/demo_{info,convert,tag,copy}.cpp
- should use "main (int..." instead of "main (unsigned int..."

* In include/id3/id3lib_strings.h
- should add #include <cstring> at the beginning

* In include/id3/writers.h
- should add #include <cstring> at the beginning

This task depends upon

Closed by  Eric Belanger (Snowman)
Monday, 26 May 2008, 00:10 GMT
Reason for closing:  Fixed
Additional comments about closing:  I've applied the patch. As mentioned here, there has been no activity in id3lib's cvs for several years. This patch is required to build id3lib from ABS but also to build other packages that links to it, e.g. easytag.
Comment by Sébastien (sebcactus) - Monday, 28 April 2008, 19:25 GMT
Hi, here is the patch to apply :)

Seb
Comment by Sébastien (sebcactus) - Saturday, 10 May 2008, 07:49 GMT
  • Field changed: Percent Complete (100% → 0%)
The patch has been submitted upstream, but the project does not have any CVS transactions from developper since 2003 (abandonned?).
I think that's also why there are already some patches applied.

Loading...