Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#10178 - [rc.sysinit] $TIMEZONE should be enclosed in quotes

Attached to Project: Arch Linux
Opened by Elifarley (elifarley) - Sunday, 13 April 2008, 12:44 GMT
Last edited by Aaron Griffin (phrakture) - Tuesday, 22 April 2008, 03:23 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

My rc.conf file has "America/Sao Paulo" configured as time zone.
Since it has a space in its name, I think references to the time zone should enclose it in quotes.

Recently, 'rc.sysinit' was changed so that "/usr/share/zoneinfo/$TIMEZONE" is now properly enclosed in quotes.

However, there still is an unquoted reference to the timezone, as we can see below:

if [ "$TIMEZONE" != "" -a -e "/usr/share/zoneinfo/$TIMEZONE" ]; then
/bin/rm -f /etc/localtime
/bin/cp /usr/share/zoneinfo/$TIMEZONE /etc/localtime
fi

I think it should read like this:
/bin/cp "/usr/share/zoneinfo/$TIMEZONE" /etc/localtime

I have attached a patch for this change.

Steps to reproduce:
In rc.conf, configure a time zone that has a space in its name, then restart your system. Something wrong should happen.
This task depends upon

Closed by  Aaron Griffin (phrakture)
Tuesday, 22 April 2008, 03:23 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in git
Comment by Thomas Bächler (brain0) - Sunday, 13 April 2008, 16:12 GMT
Same goes for rc.shutdown. I am closing 10177 as it is the exact same bug report again. One report is enough.
Comment by Thomas Bächler (brain0) - Sunday, 13 April 2008, 16:33 GMT

Loading...