FS#9217 - some packages are missing desktop-file-utils depends

Attached to Project: Arch Linux
Opened by Eric Belanger (Snowman) - Tuesday, 15 January 2008, 05:26 GMT
Last edited by Jan de Groot (JGC) - Friday, 08 May 2009, 22:21 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Tobias Kieslich (tobias)
Jan de Groot (JGC)
Aaron Griffin (phrakture)
Architecture All
Severity Low
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The desktop-file-utils dependency is needed for the .install file.
This task depends upon

Closed by  Jan de Groot (JGC)
Friday, 08 May 2009, 22:21 GMT
Reason for closing:  Fixed
Additional comments about closing:  All packages should be fixed so far. Report bugs for ones you find with this problem. One per package please.
Comment by Corrado Primier (bardo) - Tuesday, 15 January 2008, 19:03 GMT
In fact this is a really diffused bug. If you want to verify, this is the command I used for checking (run it in /var/abs):

for dir in $(find extra community -maxdepth 2 -type d) ; do [[ -e $dir/$(basename $dir).install ]] && egrep update-desktop-database $dir/*.install >/dev/null ; if [[ $? == 0 ]] ; then egrep -v ^depends=.+desktop-file-utils.+ $dir/PKGBUILD >/dev/null && basename $dir ; fi ; done

This returns 110 packages (73 in extra and 37 in community, core obviously doesn't contain desktop files) that should be fixed, and the list is not necessarily complete, since it only looks in $pkgname.install files. What should we do?
Comment by Roman Kyrylych (Romashka) - Tuesday, 15 January 2008, 19:18 GMT
I've made public Jan's excellent guidelines for Gnome packages (which are useful for anything that uses gconf/desktop-file-utils/hicolor-icon-theme/etc.) here: http://wiki.archlinux.org/index.php/Gnome_package_guidelines
Comment by Roman Kyrylych (Romashka) - Tuesday, 15 January 2008, 19:27 GMT
I've modified the title to make this report for all of affected packages.
Comment by Ronald van Haren (pressh) - Tuesday, 15 January 2008, 22:19 GMT
I've linked to the gnome_package_guidelines in the arch_packaging_standards
Comment by Jan de Groot (JGC) - Friday, 18 July 2008, 23:07 GMT
These packages do have a .install scriptlet with update-desktop-database in it, but no dependency on desktop-file-utils:
Note: check for a mimetype line in the .desktop file. Without that line, there's no need to update-desktop-database!

< ardour
< gdm
< gimp
< eclipse
< obconf
< cinepaint
< gnome-phone-manager
< xfce4-appfinder
< openoffice-base
< hugin
< banshee
< glade
< anjuta
< mirage
< xpdf
< xfce-mcs-manager
< maxima
< mousepad
< xarchiver
Comment by Glenn Matthys (RedShift) - Monday, 08 December 2008, 19:31 GMT
What's the status of this issue?
Comment by Eric Belanger (Snowman) - Monday, 08 December 2008, 19:55 GMT
We need an updated list of packages (where running update-desktop-database is needed according to .desktop file) which has this bug. Then, add these packages' maintainers to this bug report assignees.
Comment by Jan de Groot (JGC) - Saturday, 02 May 2009, 18:47 GMT
new list:
<: runs update-desktop-database, no depends on desktop-file-utils
>: depends on desktop-file-utils, but doesn't run the command

2d1
< ardour
6d4
< banshee
10,11d7
< brasero
< cinepaint
13c9,10
< devhelp
---
> desktop-file-utils
> desktop-file-utils
18d14
< eclipse
41d36
< hugin
43d37
< maxima
45,46d38
< mirage
< miro
52,53d43
< obconf
< openoffice-base
55c45
< openoffice-base-devel
---
> openoffice-base-beta
58a49
> qalculate-gtk
61d51
< ristretto
67,68c57
< stardict
< stellarium
---
> system-config-printer
73,74c62
< vinagre
< wxmaxima
---
> xarchiver
77d64
< xemacs
79d65
< xfce4-appfinder
Comment by Eric Belanger (Snowman) - Sunday, 03 May 2009, 01:58 GMT
FTR, qalculate-gtk doesn't need to be fixed. It already runs the command. I'm not sure how it ended on the list.
Comment by Jan de Groot (JGC) - Sunday, 03 May 2009, 09:25 GMT
It doesn't need to run it, as it contains no mimetypes in the .desktop file. Seems my abs checkout was not up2date when generating this list.

Loading...