FS#8920 - Is MOD_BLACKLIST needed anymore and/or what is it for?

Attached to Project: Arch Linux
Opened by kongokris 2 (nut543) - Thursday, 13 December 2007, 15:10 GMT
Last edited by Tobias Powalowski (tpowa) - Monday, 24 March 2008, 10:03 GMT
Task Type Support Request
Category System
Status Closed
Assigned To Tobias Powalowski (tpowa)
Aaron Griffin (phrakture)
Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Do MOD_BLACKLIST serve any function anymore, and if not could it be removed in the next initscript package/rel rel and a message posted to the frontpage that it has been deprecated and may stop working in a future release in favor of using !modulename?

And consequently be removed from a new rc.conf release...

Because the way it is now it is very confusing...
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Monday, 24 March 2008, 10:03 GMT
Reason for closing:  Fixed
Comment by Attila (attila) - Thursday, 13 December 2007, 21:33 GMT
I use MOD_BLACKLIST in the rc.conf so i hope it has a function and i hope it will survive. And for just the stats: The modules what i have 'blacklisted' don't get loaded so this function seems to work well.
Answer for your 'what is it for' part with a simple example: As the most pc's my pc has a parallel port but from my clients i print over the network because the printer is connected with the server. So i put 'lp parport parport_p' in the MOD_BLACKLIST array and none of them get loaded from udev. There is a wiki about the rc.conf too: http://wiki.archlinux.org/index.php/Rc.conf. I like this possibility.
Comment by Roman Kyrylych (Romashka) - Saturday, 15 December 2007, 15:34 GMT
isn't MOD_BLACKLIST=(module) the same as MODULES=(!module) ?
Comment by Tobias Powalowski (tpowa) - Sunday, 16 December 2007, 08:38 GMT
yes it is the same
Comment by kongokris 2 (nut543) - Sunday, 16 December 2007, 15:29 GMT
This is an example that i want it to be deprecated... It doesn't have to be confusing to the user if the transition is explained fully...
Comment by kongokris 2 (nut543) - Sunday, 16 December 2007, 16:02 GMT
This is an example that i want it to be deprecated... It doesn't have to be confusing to the user if the transition is explained fully...
Comment by Attila (attila) - Sunday, 16 December 2007, 17:23 GMT
Only my 2 cents: It is nice for the devs that this is the same code as '!module' but sorry, why do we want to eliminate a working solution? Is there really no one who can understand that not everybody knows what the '!' char means and for them (or people which have used a BLACKLIST functionality in their former distro) MOD_BLACKLISt is self-explanatory in contrast to have only a mixed MODULE array.
Comment by kongokris 2 (nut543) - Sunday, 16 December 2007, 22:35 GMT
Atilla, it is only a problem if ! is not explained in the comment above the MODULE array like it isnt now. Familiarity is a good thing but it shouldn't go ahead of simplicity.

See around the forum and you'll see that there are also people being confused and misunderstand _because_ two competing solutions exist now -- I don't that is worth your familiarity when a simple explanation is really only the thing needed -- in the form of a comment.
Comment by Attila (attila) - Monday, 17 December 2007, 06:10 GMT
Okay, i overseen the problem with the second line of the comment for the MODULES array ("- prefix a module with a ! to blacklist it") and from my view this "confusing" line is unneeded which is the simplest way including the fewest work. But i give it up and see what the future brings.
Comment by Aaron Griffin (phrakture) - Thursday, 20 December 2007, 18:33 GMT
I have marked this as deprecated.
http://code.phraktured.net/?p=initscripts.git;a=commitdiff;h=ab5595c4f8cdea8e6b1813701828576cbfee2fc2

The next initscripts release will contain this. I may add an install message too. At some point we will remove it. Give people a little time to adjust.

Is this clear enough for everyone?
Comment by kongokris 2 (nut543) - Friday, 21 December 2007, 13:51 GMT
good enough for me.
Comment by Attila (attila) - Friday, 21 December 2007, 14:36 GMT
Do i understand it right that you remove the line but i don't have to change my rc.conf because it will still works?
Comment by kongokris 2 (nut543) - Friday, 21 December 2007, 14:41 GMT
yup. not until it gets removed finally in an unforeseeable future... however if you want to be sure it will work in the future simply put all the modules you had in MOD_BLACKLIST into MODULES and put a ! infront of them :)
Comment by Attila (attila) - Friday, 21 December 2007, 15:37 GMT
Thanks but here my next stupid question -): Can i split the line with a '\' at the end at example in this way?
MODULES=(!module1 \
module999)
Comment by Aaron Griffin (phrakture) - Friday, 21 December 2007, 16:42 GMT
It's bash syntax. Bash will allow that *but* bash arrays are special. You don't even need the \ in there

FOO=(a
b
c
d)

Is a perfectly valid bash array.

I don't mind answering questions here and all, but this IS a bug tracker, not a forum, so can we take these questions elsewhere?
Comment by Attila (attila) - Saturday, 22 December 2007, 09:09 GMT
Thanks for your answer and i will stop asking here.
Comment by Tobias Powalowski (tpowa) - Monday, 24 March 2008, 09:47 GMT
i think we can close this, or not?
Comment by Roman Kyrylych (Romashka) - Monday, 24 March 2008, 09:53 GMT
agree

Loading...