FS#8748 - gnome-art save dialog crash

Attached to Project: Community Packages
Opened by Christoper Daley (luciferin) - Friday, 23 November 2007, 20:13 GMT
Last edited by Roman Kyrylych (Romashka) - Tuesday, 08 January 2008, 18:08 GMT
Task Type Bug Report
Category
Status Closed
Assigned To Thorbjørn Lindeijer (bjorn)
DaNiMoTh (DaNiMoTh)
Architecture i686
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Gnome-art will seg fault when a download dialog is called up.

Additional info:
* package version(s)
0.2-1
* config and/or log files etc.
/usr/lib/ruby/1.8/rexml/encoding.rb: line 34
Gtk-WARNING **:Failed to set text from markup due to error parsing markup: Error on line 3 char 33: Document ended unexpectedly while inside an attribute value
/usr/lib/ruby/1.8/rexml/encoding.rb: line 34
Gtk-WARNING **:Failed to set text from markup due to error parsing markup: Error on line 1: Character ' ' is not valid at the start of an entity name; the & character begins an entity; if this ampersand isn't supposed to be an entity, escape it as &
/usr/lib/ruby/site_ruby/1.8/gnome-art/ui/main_window.rb:253: [BUG] Segmentation fault
ruby 1.8.6 (2007-09-24) [i686-linux]

Aborted

Steps to reproduce:
Try to download a Login Manager theme. If it doesn't crash exit and reload the program and try again. It doesn't always happen on the initial use but every time after it will.

More information and proposed patches can be found here:
https://bugs.launchpad.net/ubuntu/+source/gnome-art/+bug/60258
This task depends upon

Closed by  Roman Kyrylych (Romashka)
Tuesday, 08 January 2008, 18:08 GMT
Reason for closing:  Fixed
Additional comments about closing:  The bug this is filed for has been fixed with a patch. The remaining problem is a bug in ruby-libglade
Comment by Christoper Daley (luciferin) - Tuesday, 27 November 2007, 07:25 GMT
Here's a patch that fixes the error. I've altered your PKGBUILD to apply it before compile with the following lines:

...
build() {
cd $startdir/src
patch -Np0 -i ${startdir}/src/segfault.patch || return 1
cd $pkgname
cd $pkgname
...
Comment by DaNiMoTh (DaNiMoTh) - Saturday, 15 December 2007, 17:35 GMT
i686 ok
Comment by Eric Belanger (Snowman) - Sunday, 16 December 2007, 05:48 GMT
DaNiMoTh: really?

Here it crashes on both i686 and x86_64 (I haven't tried the patch):
$ gnome-art
/usr/lib/ruby/site_ruby/1.8/libglade2.rb:105:in `guard_source_from_gc': undefined method `signal_connect' for nil:NilClass (NoMethodError)
from /usr/lib/ruby/site_ruby/1.8/libglade2.rb:98:in `guard_sources_from_gc'
from /usr/lib/ruby/site_ruby/1.8/libglade2.rb:97:in `each'
from /usr/lib/ruby/site_ruby/1.8/libglade2.rb:97:in `guard_sources_from_gc'
from /usr/lib/ruby/site_ruby/1.8/gnome-art/ui/main_window.rb:606:in `initialize'
from /usr/lib/ruby/site_ruby/1.8/gnome-art/ui/main_window.rb:606:in `new'
from /usr/lib/ruby/site_ruby/1.8/gnome-art/ui/main_window.rb:606:in `init_glade'
from /usr/lib/ruby/site_ruby/1.8/gnome-art/ui/main_window.rb:771:in `initialize'
from /usr/lib/ruby/site_ruby/1.8/gnome-art/gnome_art.rb:130:in `new'
from /usr/lib/ruby/site_ruby/1.8/gnome-art/gnome_art.rb:130:in `main'
from /usr/bin/gnome-art:25
Comment by Christoper Daley (luciferin) - Sunday, 16 December 2007, 06:31 GMT
Snowman: This sounds like you're suffering from a possible bug in ruby-libglade. I just filed a report for it so we can sort this out.
http://bugs.archlinux.org/task/8942

Also, the patch may not have propagated to community yet. I installed the latest package and it still occurs. I also posted in the AUR about the patch not being included in CVS although it is listed in the PKGBUILD.
Should we update the pkgrel to 2 for this?
Comment by DaNiMoTh (DaNiMoTh) - Sunday, 16 December 2007, 08:32 GMT
Effectly I have the same bug of Eric.

I've posted here, on the AUR page, but when I try the package, the problem remain and I forgot to delete comments.
The segfault patch is attached; I've modified some things.
I think with this we resolve the first problem... but not the second.

Comment by Christoper Daley (luciferin) - Sunday, 16 December 2007, 09:12 GMT
Well, the second one isn't a bug in gnome-art, so there's little we can do about it except require an SVN build of ruby-libglade :/
Comment by Eric Belanger (Snowman) - Monday, 07 January 2008, 23:02 GMT
I get the same crash with 0.2-2
Comment by Thorbjørn Lindeijer (bjorn) - Tuesday, 08 January 2008, 08:27 GMT
I'm not planning on fixing up this software, so if nobody else is, I think the best thing to do is to either:

1. Move it to unsupported and orphan it (of course, it'd be a buggy orphaned package)
2. Give it to another TU that is interested in fixing into it
3. Delete it

If there is no TU for option 2, I'd actually prefer the 3rd, but I'm open to other opinions.
Comment by Christoper Daley (luciferin) - Tuesday, 08 January 2008, 17:56 GMT
I'd vote for #1. As far as I know this bug is solved. The bug that's surfaced in the comments in not a problem with gnome-art; and it's fixed in ruby-libglade from svn.

But I guess it's your call. gnome-art has been abandoned by its developer, I just don't see the reason to remove the PKGBUILD from AUR when someone might find use for it. Make a newer ruby-libglade dependency/PKGBUILD if you'd like.

Loading...