FS#7054 - gensync doesn't deref. symlinked package

Attached to Project: Pacman
Opened by Michal Bozon (mykhal) - Thursday, 03 May 2007, 00:07 GMT
Last edited by Dan McGee (toofishes) - Sunday, 06 May 2007, 22:51 GMT
Task Type Bug Report
Category Scripts & Tools
Status Closed
Assigned To Aaron Griffin (phrakture)
Dan McGee (toofishes)
Architecture All
Severity Low
Priority Normal
Reported Version 2.9.8
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:
If a package on the local repo is a symlink, gensync incorrectly "calculates" package size, to be size of the symlink only (few bytes, but pacman reports 0.1 MB)

Steps to Reproduce:
- copy some bigger (>> 0.1 MB) package to /tmp
- make a symlink to it from Server directory defined for [custom] in /etc/pacman.conf (CUSTOMDIR)
- `gensync $CUSTOMDIR $CUSTOMDIR/custom.db.tar.gz'
- `pacman -Sy'
- try to install the package and see it show it is only 0.1 MB
   gensync.patch (0.5 KiB)
This task depends upon

Closed by  Dan McGee (toofishes)
Sunday, 06 May 2007, 22:51 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in my git tree
Comment by Michal Bozon (mykhal) - Thursday, 03 May 2007, 00:16 GMT
oops, I did not mention in reproduction steps one should try to install custom/PACKAGE explicitly in .. but I think no one really needs to follow them - it's simpler to look into custom.db.tar.gz generated.
Comment by Dan McGee (toofishes) - Thursday, 03 May 2007, 07:42 GMT
This seems like a valid fix, although the situations you would use symlinks in seems rather restricted.
Comment by Michal Bozon (mykhal) - Friday, 04 May 2007, 13:29 GMT
Restricted, you say.. but I use it always - maybe I'm doing something unusual way.. after I make package in /var/abs/local/package, I make a symlink /var/abs/local/package-ver-rel.pkg.tar.gz -> /var/abs/local/package/package-ver-rel.pkg.tar.gz, otherwise `gensync /var/abs/local/ /var/abs/local/custob.db.tar.gz' does not handle it.
Comment by Dan McGee (toofishes) - Friday, 04 May 2007, 17:33 GMT
I don't know if you are using pacman3 yet, but repo-add is a much easier way of generating a custom local repo.
Comment by Dan McGee (toofishes) - Sunday, 06 May 2007, 22:51 GMT
This is fixed on my git tree with repo-add. Unless someone else requests it and/or really needs it, we'll hold off on backporting it, especially since you were the first to bring it up.

Loading...