FS#6862 - Error in loading module toshiba_acpi

Attached to Project: Arch Linux
Opened by Michael Sena (mEo) - Tuesday, 10 April 2007, 02:55 GMT
Last edited by Tobias Powalowski (tpowa) - Saturday, 06 October 2007, 12:06 GMT
Task Type Bug Report
Category Packages: Current
Status Closed
Assigned To Tobias Powalowski (tpowa)
Architecture All
Severity High
Priority Normal
Reported Version 0.8 Voodoo
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The kernel new -4 release of 2.6.20, which included a patch I had requested for toshiba_acpi, is causing an error when I try to load said module toshiba_acpi.

bash-3.2$ sudo modprobe toshiba_acpi
FATAL: Error inserting toshiba_acpi (/lib/modules/2.6.20-ARCH/kernel/drivers/acpi/toshiba_acpi.ko): Device or resource busy

dmesg reports:
toshiba_acpi: Toshiba Laptop ACPI Extras version 0.19a-dev
toshiba_acpi: HCI method: \_SB_.VALZ.GHCI
toshiba_acpi: failed to register misc device 181 ("toshiba")


'sudo modprobe toshiba' works, as does 'sudo modprobe acpi'.

Thankyou for patching it, but could this new bug also be resolved? I have spent a while trying to find an answer, but I cannot.

Thanks

My laptop is:
Toshiba Satellite A50

uname -a is:
Linux meo 2.6.20-ARCH #1 SMP PREEMPT Mon Apr 9 16:29:54 CEST 2007 i686 Intel(R) Pentium(R) M processor 1.60GHz GenuineIntel GNU/Linux
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Saturday, 06 October 2007, 12:06 GMT
Reason for closing:  Won't fix
Comment by Tobias Powalowski (tpowa) - Tuesday, 10 April 2007, 05:15 GMT
hrm did you use your option too?
parm: hotkeys_over_acpi:uint
Comment by Tobias Powalowski (tpowa) - Tuesday, 10 April 2007, 06:14 GMT
the toshiba_acpi.c files are now identical with ubuntu's despit from the bluetooth patch, it should work
Comment by Michael Sena (mEo) - Tuesday, 10 April 2007, 07:35 GMT
Hi, do you know when abouts this will be included, or when the next kernel release will be?

Thanks
Comment by Tobias Powalowski (tpowa) - Wednesday, 11 April 2007, 05:08 GMT
i think it will never be included or not soon, the bluetooth patch exists since .14 series and the acpi patch since .17 series
Comment by Michael Sena (mEo) - Wednesday, 11 April 2007, 05:31 GMT
i don't need bluetooth btw, its my hotkeys that aren't working,
but in your previous comment you said 'it should now work', but if its never going to be included...?? I don't understand you
Comment by Tobias Powalowski (tpowa) - Wednesday, 11 April 2007, 18:40 GMT
as i understood you:on ubuntu your stuff works, now the code is 100% identicall to ubuntu.
the bluetooth patch and the ubuntu one are not patches from upstream someone wrote them and put them online, they are in no git tree on kernel.org.
Comment by Michael Sena (mEo) - Friday, 13 April 2007, 01:35 GMT
Yes, you understood me right. My question was when will the 100% identical code be included? If so when, if not why not?
Comment by Tobias Powalowski (tpowa) - Friday, 13 April 2007, 15:33 GMT
the code in kernel is done by the kernel devs, when linus decides to add it, it will be added or if not then not.
i doubt it will be added, because the patches are out there since a long time.
the module now should work as on ubuntu, if not something else is missing.
it was your request to have it added, if it's not working i'll remove it again on next kernel.
I don't have such hardware, provide me with working patches and i'll add them again.
Comment by eliott (cactus) - Wednesday, 08 August 2007, 05:05 GMT
Reopen request had this text:

> qwerty (qwerty) -- Requested task to be re-opened
> The toshiba_acpi patch is still in new kernels (kernel26 2.6.21.5-1 and kernel26ck 2.6.21-ck2-1)

Not sure what that means.
Tobias? Any ideas?

Feel free to reclose if it doesn't make sense.
Comment by Tobias Powalowski (tpowa) - Wednesday, 08 August 2007, 18:57 GMT
sorry no idea, it's still in kernel this patch
Comment by qwerty (qwerty) - Wednesday, 19 September 2007, 17:18 GMT
The toshiba_acpi patch is still in new kernels (kernel26 2.6.21.5-1 and kernel26ck 2.6.21-ck2-1)
Comment by Thomas Bächler (brain0) - Wednesday, 19 September 2007, 17:19 GMT
The patch must be removed from the kernel. Probably some others also need to be removed, we should not keep crap around just because patch still applies it.
Comment by Michael Sena (mEo) - Thursday, 20 September 2007, 09:11 GMT
No, it is important for this patch to stay in. It fixes an issue with mine and others laptop media keys.
The toshiba_acpi patch in the newer kernels, as far as I've tested, has not been fixed for this particular situation.
Comment by Tobias Powalowski (tpowa) - Thursday, 20 September 2007, 12:29 GMT
so which system we want to break now`? should we throw a coin?
Comment by Thomas Bächler (brain0) - Thursday, 20 September 2007, 14:47 GMT
If a patch fixes one system and breaks another one, we stay vanilla.

Loading...