FS#6791 - makepkg doesn't remove installed dependencies on other failures before build()

Attached to Project: Pacman
Opened by Roman Kyrylych (Romashka) - Monday, 02 April 2007, 15:19 GMT
Last edited by Roman Kyrylych (Romashka) - Tuesday, 05 June 2007, 14:28 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Dan McGee (toofishes)
Architecture All
Severity Low
Priority Normal
Reported Version 3.0.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

[roman@home isomaster]$ makepkg -Ssr
==> Entering fakeroot environment
==> Making package: isomaster 0.8.1-1 (Пнд Кві 2 18:17:46 EEST 2007)
==> Checking Runtime Dependencies...
==> Checking Buildtime Dependencies...

==> Installing missing dependencies...
ERROR: ld.so: object 'libfakeroot.so' from LD_PRELOAD cannot be preloaded: ignored.
resolving dependencies... done.
looking for inter-conflicts... done.

Targets: iniparser-2.16-1

Total Package Size: 0,10 MB

Proceed with installation? [Y/n]
:: Retrieving packages from community...
iniparser 9,9K 41,2K/s 00:00:00 [#####################] 100%
checking package integrity... done.
cleaning up... done.
(1/1) checking for file conflicts [#####################] 100%
(1/1) installing iniparser [#####################] 100%
==> Retrieving Sources...
-> Downloading isomaster-0.8.1.tar.bz2
--18:17:55-- http://littlesvr.ca/isomaster/releases/isomaster-0.8.1.tar.bz2
=> `isomaster-0.8.1.tar.bz2'
Визначення імені littlesvr.ca... 216.8.128.218
Connecting to littlesvr.ca|216.8.128.218|:80... під'єднано.
HTTP-запит надіслано, очікуєм відповіді... 200 OK
Довжина: 205.535 (201K) [application/x-tar]

100%[====================================>] 205.535 6.75K/s ETA 00:00

18:18:24 (8.54 KB/s) - `isomaster-0.8.1.tar.bz2' saved [205535/205535]

-> Found makefile.patch in build dir
==> Validating source files with md5sums
isomaster-0.8.1.tar.bz2 ... FAILED
makefile.patch ... Passed
==> ERROR: One or more files did not pass the validity check!
This task depends upon

Closed by  Roman Kyrylych (Romashka)
Tuesday, 05 June 2007, 14:28 GMT
Reason for closing:  Fixed
Additional comments about closing:  in git
Comment by Roman Kyrylych (Romashka) - Monday, 02 April 2007, 15:45 GMT
Here's quick patch.
However maybe it would be better to have some do_exit(<errorcode>) function that will cleanup things before exit.
   remodedeps.patch (2.1 KiB)
Comment by Dan McGee (toofishes) - Monday, 02 April 2007, 15:49 GMT
This patch looks sane, we'll probably use this in CVS and look into a better solution for makepkg 3.1.

Loading...