FS#4681 - shfs and fuse support in initscripts

Attached to Project: Arch Linux
Opened by Roman Kyrylych (Romashka) - Monday, 22 May 2006, 13:56 GMT
Last edited by Judd Vinet (judd) - Tuesday, 25 July 2006, 22:21 GMT
Task Type Bug Report
Category System
Status Closed
Assigned To Judd Vinet (judd)
Architecture not specified
Severity Medium
Priority Normal
Reported Version 0.7.1 Noodle
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Complete list of fixes:
/etc/rc.d/netfs - added support for shfs and fuse, capitalized message
/etc/rc.sysinit - added support for shfs, codafs and fuse, fixed fsck reporting fstab errors caused by fuse entries.

Now FUSE filesystems are treated as network filesystems and can be started from fstab with entries like:
sshfs#root@alpha.virtual.net:/var/cache/pacman/pkg/ /var/cache/pacman/pkg fuse rw,reconnect 0 0
and there will be no fsck messages about errors in fstab (caused by # char).
This task depends upon

Closed by  Judd Vinet (judd)
Wednesday, 08 November 2006, 20:00 GMT
Reason for closing:  Implemented
Comment by Roman Kyrylych (Romashka) - Sunday, 02 July 2006, 09:51 GMT
I have updated files to the latest initscripts.
Please include this fix in the next initscripts. These are trivial fixes and they works for me few months and doesn't break anything.
Comment by Judd Vinet (judd) - Tuesday, 04 July 2006, 17:11 GMT
Do we include the shfs module in the arch kernel? I can't find it.
Comment by Roman Kyrylych (Romashka) - Wednesday, 05 July 2006, 08:57 GMT
No, because it is not included in vanilla kernel. shfs is in Community.
There are two ssh-based remote filesystems: sshfs (which requires fuse) and shfs (standalone kernel module). Both of them (and all fuse filesystems) need these proposed fixes to work seemly from fstab.

I see that you are preparing a bunch of fixes for the next initscripts release. Please include these fixes too.
Comment by Wael Nasreddine (Gandalf) - Wednesday, 19 July 2006, 08:58 GMT
@Judd even if shfs isn't included in -current, this small fix will give full support to whom is actually using it
Comment by Judd Vinet (judd) - Tuesday, 25 July 2006, 22:24 GMT
Re-opened by Roman Kyrylych:

Please add 2>/dev/null to /sbin/fsck -A -T -C -a -t $NETFS $FORCEFSCK as in my proposal or else when fuse or shfs will be mounted on boot user will see fsck messages about errors in fstab (that's because fsck doesn't like # char)

And please change "Unmounting network filesystems" to "Unmounting Network Filesystems" for better consistency with "Mounting Network Filesystems" in netfs.

PS: intoducing $NETFS was nice idea! :-)
Comment by Judd Vinet (judd) - Tuesday, 25 July 2006, 22:32 GMT
>> Please add 2>/dev/null to /sbin/fsck -A -T -C -a -t $NETFS $FORCEFSCK as in my proposal or else when fuse or shfs will be mounted on boot user will see fsck messages about errors in fstab (that's because fsck doesn't like # char)

Hmm, that's a bit of a problem for me. Some users may very well want to see the output from fsck, since it could contain useful information if they have filesystem issues.

>> And please change "Unmounting network filesystems" to "Unmounting Network Filesystems" for better consistency with "Mounting Network Filesystems" in netfs.

Sure.
Comment by Judd Vinet (judd) - Tuesday, 25 July 2006, 22:32 GMT
I suppose we could test. Does fsck spit out the useful information on stdout or stderr?
Comment by Roman Kyrylych (Romashka) - Wednesday, 26 July 2006, 05:49 GMT
I use this almost 5 months already and I always see useful fsck messages. Only messages about errors in fstab go to stderr, but # char is not an error, it is required by fuse and shfs (at least). The most correct fix would be to patch fsck, but IMHO redirecting stderr to /dev/nul is not bad workaround.
Comment by Roman Kyrylych (Romashka) - Saturday, 09 September 2006, 09:48 GMT
I see initscripts-0.7.2-7 moved to Current. :-) But you didn't include redirection of fsck stderr messages to /dev/null.
Line 140 should be /sbin/fsck -A -T -C -a -t $NETFS $FORCEFSCK 2>/dev/null
I'm sure that fsck doesn't output any usefull info to stderr except errors in fstab. These errors are false in case of using fuse or shfs, which means that on every boot usersof fuse or shfs will get those error messages visible (of course, fuse and shfs are mounted correctly after that but these messages are annoying).
Messages about errors in filesystem are produced to stdout. I've had few filesystem problems and didn't miss any usefull otput from fsck with my patched initscripts. So I'm pretty sure it is safe to redirect fsck stderr output to /dev/null.

Of course it would be better if this false error messages were fixed in mainstream (directly in fsck), or maybe apply patch to fix it, but I cannot supply such patch.
Comment by Roman Kyrylych (Romashka) - Thursday, 26 October 2006, 08:46 GMT
Judd, please add 2>/dev/null and close this trivial bug finally. ;-)

Loading...