FS#20669 - [git] package installs gitk but not gitk's dependencies
Attached to Project:
Arch Linux
Opened by Jan Dlabal (y27) - Monday, 30 August 2010, 01:13 GMT
Last edited by Dan McGee (toofishes) - Monday, 05 September 2011, 12:48 GMT
Opened by Jan Dlabal (y27) - Monday, 30 August 2010, 01:13 GMT
Last edited by Dan McGee (toofishes) - Monday, 05 September 2011, 12:48 GMT
|
Details
Description:
This issue arrised in the forum post here: https://bbs.archlinux.org/viewtopic.php?pid=817963 In my opinion including gitk in the git package while making the dependencies necessary for gitk (tcl, tk) optional in the git package does not make sense. I think that optional dependencies should be used only for parts of applications that are not necessarily needed -- as an example let's say you are installing an editor and there is an optional dependency which is a plugin to enable syntax colorization for some language. However, it doesn't make sense to even install gitk if it can't be used with the minimal dependencies -- I assume that if I don't get gitk : command not found, it should be able to start. For this reason, (not only) I think that it would be more logical and intuitive to provide a separate gitk package where tcl and tk would be required dependencies, and a git package without gitk. |
This task depends upon
Closed by Dan McGee (toofishes)
Monday, 05 September 2011, 12:48 GMT
Reason for closing: Won't implement
Additional comments about closing: Don't reopen a bug I've made a subjective decision on. You're not going to change my mind here.
Monday, 05 September 2011, 12:48 GMT
Reason for closing: Won't implement
Additional comments about closing: Don't reopen a bug I've made a subjective decision on. You're not going to change my mind here.
What I would suggest is to use PKGBUILD.nogui for the current git package, which would therefore only install non-GUI components of git and therefore would not need tcl/tk.
The second patch PKGBUILD.gui, which should be used for a git with gui package, say git-gui. Everything else could just be copied from the current git package.
I also disagree with your characterization of optdepends; we also don't split packages just for kicks around here, especially if depends aren't being dragged in and you are expected to read pacman output.
You say: "I'm just not feeling the need for a split package here;"
That's your opinion, I can consider that 2 package rather than only one can be a better solution (I don't mind).
Problem is that gitk has been included and not tcl/tk package that are required dependencies to run gitk.
Have a look at the issue discussed https://bbs.archlinux.org/viewtopic.php?pid=817963 , error message returned by gitk is just incomprehensible ;-)
@flagos: I'm going to disagree with you regarding the error message; it's not cryptic. When confronted with "wish: not found", an Archer's next step should be to find the package which provides this 'wish' command thingy. Or google the error message. Or read https://wiki.archlinux.org/index.php/Git. :)