FS#20638 - [mkinitcpio] gen_init_cpio obviously fails but mkinitcpio still prints SUCCESS

Attached to Project: Arch Linux
Opened by Jan Dlabal (y27) - Friday, 27 August 2010, 17:28 GMT
Last edited by Andrea Scarpino (BaSh) - Friday, 18 February 2011, 07:08 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Description:

mkinitcpio version 0.6.7-1 seems to ignore what happens to gen_init_cpio, and says SUCCESS even if gen_init_cpio reports errors. The errors reported by gen_init_cpio are those in my forum post at https://bbs.archlinux.org/viewtopic.php?id=103655.

According to falconindy, this could be fixed by setting pipefail in the shell before executing the command, since otherwise the command is checking the return value of gzip but not gen_init_cpio.
This task depends upon

Closed by  Andrea Scarpino (BaSh)
Friday, 18 February 2011, 07:08 GMT
Reason for closing:  Fixed
Additional comments about closing:  See commit 3fbbcdf2480bc091f44c7b15d875f313ac7ddbed
Comment by Glenn Matthys (RedShift) - Monday, 15 November 2010, 12:23 GMT
What's the status of this issue?
Comment by Thomas Bächler (brain0) - Monday, 15 November 2010, 12:55 GMT
It hasn't been looked at yet, I haven't had the chance to do much mkinitcpio work. A patch against the current git master will speed things up though.
Comment by Dave Reisner (falconindy) - Monday, 15 November 2010, 13:40 GMT
Patch attached.
   0001-Set-pipefail-before-runn... (0.9 KiB)

Loading...