Arch Linux

Comments:
1. We try not to use backticks anymore in scripts, but instead prefer $() syntax.
2. Because we start it manually for the root device, should we also be stopping it in rc.shutdown? The manpage of mount.nilfs2 seems to indicate that if started manually, the GC daemon needs to be stopped manually as well.

1.) new patch attached with fix
2.) SIGTERM on shutdown is enough to bring down the nilfs garbage collector:

man nilfs_cleanerd ->

" SIGTERM
The nilfs_cleanerd will exit cleanly."

Thomas, as an FYI, I looked this over at ArchCon with Alex and everything is pretty solid.

this line:
if [ -n $nilfs_root_dev ];
should be:
if [ -n "$nilfs_root_dev" ];

(try this on your terminal: [ -n $somevarthatdoesnotexist ] && echo nonzero)

I've fixed up my changes with your input and also made the variable naming consistent with the rest of the rc script.

BASH is damn hard to get right :P

Thanks for the help.

what's the status of this? Can this be merged?

It has my signoff, just merge it into one patch, but we don't really have anyone looking at the 20+ initscripts issues right now unfortunately and I can't put them on my plate.

Hmm.. I don't see why it is necessary to start the nilfs_cleanerd manually. It should be started automatically by the mount command, and the manual page for nilfs_cleanerd even says this is the recommended way to start it.
This is possible to do even for the root filesystem. See  FS#22523  for an two-line patch and an explanation how.

I just linked the issues, so I'm pretty sure I saw how to do it so you don't need to call it out here. :) Things have also changed a lot in the seven months since this bug was opened, so please take that into account next time you assume the original poster didn't know what they were doing. And none of this matters for anything but the root filesystem, for that matter.

Sorry, didn't know you were the only one who needed to know, so I thought it would be nice to have a link to a more up-to-date solution here for future reference..

Also I'll leave you to assume what I assume, but let me ask a question then:

What is holding this issue up right now? I know this isn't the complete solution to running nilfs as root (you still need to make udev create the /dev/root symlink), but what is blocking this change from being merged?

We don't have a real active initscripts developer at the moment, this is just 1 of 42 open issues right now, so patience will be needed. Hopefully things get addressed in the next couple of weeks.

@Dan,Alex: do you agree that the patch in  FS#22523  is preferable to the one posted here? (I don't have NILFS to try this out, so I'll rely on your judgement).
@Dan: you mentioned that you linked the tasks, I don't see the link, did something change?

@Dan: sorry, I found the link.

@Tom: The other patch looks much better to me. I'll test it out when I get a chance.

If i understand correctly, garbage collector is not mandatory to be mounted rw. Why don't start it in an rc.d script which can be bundled with package nilfs2, rathan than in rc.sysinit?

@Seb: if that's correct then I would prefer that compared to adding workarounds in rc.sysinit. It looks to me that neither is needed though, and that this is just an udev/util-linux issue (see  FS#22523 ).