FS#19633 - [gcc] GCC 4.5.0-2 breaks KHTML (css)

Attached to Project: Arch Linux
Opened by Alex Fiestas (afiestas) - Friday, 28 May 2010, 20:04 GMT
Last edited by Allan McRae (Allan) - Thursday, 03 June 2010, 01:48 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
If you build khtml (the css parser) using gcc 4.5.0-2 the generated code will be broken, ending in a crash due to a mistake handling pointers.

Additional info:
* gcc 4.5.0-2

Steps to reproduce:
Build khtml using gcc 4.5.0-2, then try to use any application that uses it (konqueror).

I've been told that kde-unstable repo also has this problem.

After talk with SadEagle (developer of KHTML) we end up in this thread:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44258

I'm posting it here so archlinux developers can track the bug.

Thanks
This task depends upon

Closed by  Allan McRae (Allan)
Thursday, 03 June 2010, 01:48 GMT
Reason for closing:  Fixed
Additional comments about closing:  gcc-4.5.0-4
Comment by Ronald van Haren (pressh) - Monday, 31 May 2010, 10:02 GMT
kde 4.4.4 will be released tomorrow, there hasn't been a commit in kdelibs/khtml which can fix this on that side. That means that we can't push a new kde version or do any rebuilds that require a kdelibs rebuild.

Should we revert the gcc commit causing this (not sure what the implications of this are) or do you think there will be a fix available soon?
Comment by Alex Fiestas (afiestas) - Monday, 31 May 2010, 10:19 GMT
Well I have been talking with SadEagle (Main developer of khtml) about this issue for days, since everything is pointing to a GCC error he won't patch the css code to workaround this bug (In fact, patch this issue at kthml level is almost impossible since the pointers are messed up).

So imho we should revert the gcc commit since as said in the gcc bugtrack it should be safe.

Comment by Allan McRae (Allan) - Monday, 31 May 2010, 12:28 GMT
Reverting that patch is fine until a proper fix is available (it does not fix a "real" bug, just some code clean-up issues). I doubt I can get to this until Wednesday so if you really need it in the next 36 hours, someone else will have to do the build.
Comment by Alex Fiestas (afiestas) - Monday, 31 May 2010, 12:30 GMT
Is not an option to build kdelibs using the 4.5.0-1 instead of 4.5.0-2 ?
Comment by Ronald van Haren (pressh) - Monday, 31 May 2010, 12:39 GMT
Well we can but I prefer a clean solution. Use of ABS will be broken for some time and we have no idea for how long. Sure if we know a fix is released in a few days it would be perfectly fine, but it may also take much longer. Also other packages may or may not be affected by this bug.
Comment by Alex Fiestas (afiestas) - Monday, 31 May 2010, 14:41 GMT
So, can we wait until Allan compile the "patch reverted" gcc to release the KDE 4.4.4 ? If not I can help with my laptop if needed (64bits) but I have no experience in packaging :(
Comment by Ronald van Haren (pressh) - Monday, 31 May 2010, 14:46 GMT
I'm already compiling gcc for both architectures with that commit reverted. Plan is still to release tomorrow but it depends a bit on when everything finishes compiling of course and issues we may encounter.
Comment by Allan McRae (Allan) - Monday, 31 May 2010, 22:07 GMT
@Ronald: Are you uploading the new gcc packages or are they just for internal use?
Comment by Ronald van Haren (pressh) - Tuesday, 01 June 2010, 03:30 GMT
I'll upload them once I verified the kde builds are fine in a few hours

edit: will take a bit longer, the builds failed at some point due to a too new kde-support lib

Loading...