FS#18424 - [namcap] Add support for multiple compression types

Attached to Project: Arch Linux
Opened by Pierre Schmitz (Pierre) - Monday, 22 February 2010, 06:44 GMT
Last edited by Dan McGee (toofishes) - Monday, 01 March 2010, 05:08 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Dan McGee (toofishes)
Hugo Doria (hdoria)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Namcap currently doesn't support any compression except gzip. The attached patch includes a wrapepr script which decompresses gzip, bz2 and xz archives and just forwards the pure tar to namcap.

This is meant as a workaround until those compression types are supported within python.

When applying this patch the following line has to be removed from the PKGBUILD:

ln -s namcap.py ${pkgdir}/usr/bin/namcap || return 1
   0001-Use-a-wrapper-script-to-... (2.3 KiB)
This task depends upon

Closed by  Dan McGee (toofishes)
Monday, 01 March 2010, 05:08 GMT
Reason for closing:  Fixed
Additional comments about closing:  2.5
Comment by Eric Belanger (Snowman) - Monday, 22 February 2010, 16:30 GMT
As Hugo is currently inactive, I've added Dan who seem to have access to the master branch.
Comment by Dan McGee (toofishes) - Monday, 22 February 2010, 17:18 GMT
I'll take a look at this soon, and then we can get a new release out.
Comment by Eric Belanger (Snowman) - Monday, 22 February 2010, 18:20 GMT
BTW, there are a lot of bug reports for namcap. Maybe you could go through them and apply any trivial fixes or improvements. If you have the time and interest to do so, of course.

BTW, this one is a trivial typo:
http://bugs.archlinux.org/task/15591#comment48110
Comment by Eric Belanger (Snowman) - Monday, 22 February 2010, 23:31 GMT
You might want to put a loop in your wrapper script so we can use more that one argument. So we could run namcap on the PKGBUILD and all packages that it produces in one step like before.

Also, I tried doing your changes locally but it doesn't work. Sending the uncompressed package to namcap.py directly doesn't even work:

$ namcap.py freeciv-2.2.0-1-x86_64.pkg.tar
Error: Cannot process freeciv-2.2.0-1-x86_64.pkg.tar

Comment by Allan McRae (Allan) - Tuesday, 23 February 2010, 05:19 GMT
With this patch, can we remove namcap.py from /usr/bin. No files ending in .py should really be there.
Comment by Pierre Schmitz (Pierre) - Tuesday, 23 February 2010, 05:21 GMT
Yes, I just didn't know how this setup.py works. :-)
Comment by Pierre Schmitz (Pierre) - Wednesday, 24 February 2010, 04:07 GMT
I have updated the patch attached to this report. It now supports multiple packages passed to namcap, it passes additional parameters through and namcap.py is longer installed to /usr/bin.
Comment by Dan McGee (toofishes) - Wednesday, 24 February 2010, 05:26 GMT
I'm going to email to the ML for peer review since that is impossible here. It still needs a tad bit of work but is close.

Loading...