FS#18258 - [pulseaudio] fails a lot of checks in namcap

Attached to Project: Community Packages
Opened by Damjan Georgievski (damjan) - Tuesday, 09 February 2010, 20:19 GMT
Last edited by Corrado Primier (bardo) - Thursday, 11 February 2010, 16:05 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Corrado Primier (bardo)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I discovered this after the discussion that policykit is no longer needed in Arch, but I've found that it is required by the pulseaudio-0.9.21-3 package.

Then I run namcap on it, and this is the result:

pulseaudio W: Dependency included and not needed ('consolekit')
pulseaudio W: Dependency included and not needed ('liboil')
pulseaudio W: Dependency included and not needed ('policykit')
pulseaudio W: Dependency included but already satisfied ('libcap')
pulseaudio W: File (var/pulse) exists in a non-standard directory.

There's a lot of other error reports about insecure "Insecure RPATH" about all the modules, but maybe it has to be like that.

There's a lot of "Dependency detected and not included" for the modules, but those dependencies are in optdepends so this is a namcap problem actually
This task depends upon

Closed by  Corrado Primier (bardo)
Thursday, 11 February 2010, 16:05 GMT
Reason for closing:  Fixed
Additional comments about closing:  The package got a major dependency overhaul and should now be ok. I didn't integrate Lennart's patches, but I'm considering doing it in a future build.
Comment by Ionut Biru (wonder) - Tuesday, 09 February 2010, 21:44 GMT
namcap is not a tool that meant to be perfect. you can't trust the output so much.
About RPATH, is a bug in namcap who only check for /usr/lib but not for /usr/lib/$package  FS#14049 

i don't consider this report be a bug.
Comment by Damjan Georgievski (damjan) - Tuesday, 09 February 2010, 21:46 GMT
Well I removed policykit and pulseaudio still works
Comment by Ionut Biru (wonder) - Tuesday, 09 February 2010, 21:57 GMT
is true that consolekit and policykit can be removed. i was pointing out that namcap is not always right and the maintainer should look carefully if he wants to remove a dependency.
Comment by Corrado Primier (bardo) - Wednesday, 10 February 2010, 08:11 GMT
Thanks for reporting, I'm going to rebuild ASAP (together with the deps that need it). As Ionut said, however, don't always trust namcap's output :) Besides the RPATH glitch there are other things that namcap won't get right, even in dependency checking. For example, liboil is indeed a dependency, you can also see it in the gentoo ebuild, which is maintained by one of the pulseaudio devs: http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-sound/pulseaudio/pulseaudio-0.9.21.1.ebuild?view=markup

Anyway, the *kit dependencies have indeed been removed and I'll take action, thanks.
Comment by Jan de Groot (JGC) - Wednesday, 10 February 2010, 14:26 GMT
I think you might want to have a look at the specfile at fedora instead. It's maintained by Lennart himself. Note that Lennart is always trashing gentoo in his blogposts and release notes, so I wouldn't trust Gentoo as primary source for pulseaudio.

http://cvs.fedoraproject.org/viewvc/devel/pulseaudio/pulseaudio.spec?revision=1.109&view=markup

Also note the "rtkit" dependency:
http://cvs.fedoraproject.org/viewvc/F-12/rtkit/rtkit.spec?revision=1.4&view=markup

This rtkit replaces the previous calls to policykit.
Comment by Corrado Primier (bardo) - Wednesday, 10 February 2010, 14:39 GMT
The problem with Lennart's work as a packager is he patches the hell out of PA because "releasing takes too much time". This obviously only spares time to him, and wastes that of other packagers, so as I previously stated on another ticket I won't be using his patches if not absolutely necessary and I'll stick to stable releases. It also means that I can't trust his dependency list since he sometimes adds new features in his Fedora patches.
Comment by Jan de Groot (JGC) - Wednesday, 10 February 2010, 15:26 GMT
realtimekit support is in the stable release, and liboil was removed a few versions before the last stable release. You should grep for dependencies, in case of liboil I only found a reference in Changelog that tells that they got rid of it.

As for the patches: yes, it's a shitload of patches. Basically it's this git tree:
http://git.0pointer.de/?p=pulseaudio.git;a=shortlog;h=refs/heads/stable-queue

If you decide to take those patches, consider using git to build a big patch with all the commits from that queue.

Loading...