FS#17802 - [openbox] mistake in /usr/bin/openbox-gnome-session

Attached to Project: Arch Linux
Opened by Eugene Arshinov (statc) - Tuesday, 12 January 2010, 16:24 GMT
Last edited by Andrea Scarpino (BaSh) - Tuesday, 26 January 2010, 16:32 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Andrea Scarpino (BaSh)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

There is a little mistake in /usr/bin/openbox-gnome-session script:

<...>
# make sure openbox is going to be run
if test -z "$SESSION"; then
# if its empty then just run openbox
SESSION="[openbox]"
elif test -z $(echo "$SESSION" | grep -q openbox); then
# if openbox isn't in the session then append it
SESSION="${SESSION%]},openbox]"
fi
<...>

`grep -q' never prints anything, so `test -z $(...)' will always evaluate to "true".

openbox 3.4.10-1
This task depends upon

Closed by  Andrea Scarpino (BaSh)
Tuesday, 26 January 2010, 16:32 GMT
Reason for closing:  Fixed
Additional comments about closing:  openbox 3.4.10-3
Comment by Andrea Scarpino (BaSh) - Tuesday, 12 January 2010, 16:39 GMT
  • Field changed: Summary (Mistake in /usr/bin/openbox-gnome-session → [openbox] mistake in /usr/bin/openbox-gnome-session)
  • Field changed: Status (Unconfirmed → Assigned)
  • Field changed: Category (Packages: Extra → Upstream Bugs)
  • Task assigned to Andrea Scarpino (BaSh)
hi, please report this upstream
Comment by Eugene Arshinov (statc) - Tuesday, 12 January 2010, 17:18 GMT
Done: http://bugzilla.icculus.org/show_bug.cgi?id=4492
Comment by tuxce (tuxce) - Tuesday, 26 January 2010, 00:17 GMT
  • Field changed: Percent Complete (100% → 0%)
wrong patch in openbox package: fix-bug-in-openbox-gnome-session.patch

elif echo "$SESSION" | grep -q openbox; then
should be:
! elif echo "$SESSION" | grep -q openbox; then

comment posted upstream too.

Loading...