FS#17588 - [gqview] ignores files on mounted CIFS

Attached to Project: Arch Linux
Opened by Dmytro Bagrii (dimich) - Wednesday, 23 December 2009, 09:50 GMT
Last edited by Dan Griffiths (Ghost1227) - Saturday, 13 February 2010, 04:02 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Tobias Kieslich (tobias)
Architecture i686
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Gqview ignores files on mounted CIFS filesystem (and maybe some another remote filesystems).

To get file information gqview uses struct stat which have 32-bit st_ino field, but inodes on mounted CIFS filesystem are 64-bits wide and doesn't fit to 32 bits. stat() function returns EOVERFLOW, but gqview doesn't check errno value and just skips such files and directories.
If i define macro _FILE_OFFSET_BITS=64, i.e. patch PKGBUILD with:

17c17
< ./configure --prefix=/usr --mandir=/usr/share/man || return 1
---
> CPPFLAGS="-D_FILE_OFFSET_BITS=64" ./configure --prefix=/usr --mandir=/usr/share/man || return 1

and build it, it works good. I guess this macro should be defined by autotools or in another way, but not in PKGBUILD, i've patched PKGBUILD just to check if it works.

BTW, the same behaviour have geeqie, xzgv and gimageview.

Gqview version: 2.0.4-2
This task depends upon

Closed by  Dan Griffiths (Ghost1227)
Saturday, 13 February 2010, 04:02 GMT
Reason for closing:  Fixed
Comment by Thomas Dziedzic (tomd123) - Thursday, 24 December 2009, 06:22 GMT
"I guess this macro should be defined by autotools or in another way, but not in PKGBUILD"

gqview isn't developed anymore, so a pkgbuild would be the only place you could patch it.
Comment by Dmytro Bagrii (dimich) - Thursday, 24 December 2009, 17:50 GMT
Also packager's /etc/makepkg.conf is possible place for preprocessor flags. But it will affect another packages, i don't know is it bad or good. Let people responsible for this package decide where to put it.