FS#16435 - [kernel26] Revert bad commit to joydev
Attached to Project:
Arch Linux
Opened by (beomuex) - Friday, 02 October 2009, 16:42 GMT
Last edited by Paul Mattal (paul) - Saturday, 06 February 2010, 13:58 GMT
Opened by (beomuex) - Friday, 02 October 2009, 16:42 GMT
Last edited by Paul Mattal (paul) - Saturday, 06 February 2010, 13:58 GMT
|
Details
A commit to the joydev module in 2.6.30's upstream broke the
support for joysticks with many buttons (like the Saitek X52
series).
There's a patch available to revert this bad commit. http://bugzilla.kernel.org/show_bug.cgi?id=14049 Since many other distributions have already reverted this commit, it shouldn't affect any other functionalities of joydev. |
This task depends upon
Closed by Paul Mattal (paul)
Saturday, 06 February 2010, 13:58 GMT
Reason for closing: Won't fix
Additional comments about closing: It appears kernel devs have decided not to fix this. Reopen against 2.6.33 if it's not fixed in that line.
Saturday, 06 February 2010, 13:58 GMT
Reason for closing: Won't fix
Additional comments about closing: It appears kernel devs have decided not to fix this. Reopen against 2.6.33 if it's not fixed in that line.
I suppose this is fixed in .31 already.
I'm not sure we should patch stuff ourselves. The commit fixes one bug and introduces another - which one is more important and for how many users?
For referrence: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/300143
http://tinyurl.com/ya77lfj
The latest patch-2.6.31.1-1-ARCH.bz2 doesn't include the fix either.
Having been in kernel patching quandaries myself, my feeling is it's okay to patch a small bug if it helps out a lot of people, but NOT if it clearly introduces some other issue. So based on my limited knowledge of this situation, I'd be in favor of not patching here if it introduces another issue.
Not sure if this info is valuable, but I applied diff (from http://bugzilla.kernel.org/show_bug.cgi?id=14049), compiled kernel, and now my Saitek X52 is functioning properly.
-Adam