FS#16004 - makepkg: checking PKGBUILD sanity misses variables in split packages

Attached to Project: Pacman
Opened by Allan McRae (Allan) - Saturday, 05 September 2009, 03:09 GMT
Last edited by Allan McRae (Allan) - Wednesday, 03 August 2011, 11:57 GMT
Task Type Bug Report
Category General
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version 3.3.0
Due in Version 4.0.0
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Summary and Info:
Anything defined in the package functions is missed when checking PKGBUILD sanity.
This task depends upon

Closed by  Allan McRae (Allan)
Wednesday, 03 August 2011, 11:57 GMT
Reason for closing:  Fixed
Comment by Xavier (shining) - Sunday, 11 October 2009, 22:24 GMT
My proposal to change the split pkgbuild slightly by including all variables at the top level would also help a lot for this, right ?
But I still didn't try to see how doable that was.
Comment by Dan McGee (toofishes) - Sunday, 11 October 2009, 22:28 GMT
Yeah, we had this conversation a while back and I'm just not seeing a sane route any other way. In addition, the current format is damn hard to parse by anything but bash; moving these up and having some naming convention would make it a lot easier for other tools to parse.
Comment by Allan McRae (Allan) - Sunday, 11 October 2009, 22:41 GMT
My main problem with changing the format is that I have yet to see a suggest that does not make the PKGBUILD damn hard to read. But I agree that the current format is not fun to parse...
Comment by Allan McRae (Allan) - Monday, 26 April 2010, 09:02 GMT
Patch for install and changelog file checks: http://mailman.archlinux.org/pipermail/pacman-dev/2010-April/010640.html
Comment by Allan McRae (Allan) - Tuesday, 07 December 2010, 07:54 GMT
Patch for optdepends, backup, provides: http://mailman.archlinux.org/pipermail/pacman-dev/2010-December/012042.html

Remaining overrides to check: options, pkgver/pkgrel, arch...
Comment by Allan McRae (Allan) - Friday, 22 July 2011, 12:49 GMT
And the final variable checks....

pkgver/pkgrel - http://mailman.archlinux.org/pipermail/pacman-dev/2011-July/013894.html
arch - http://mailman.archlinux.org/pipermail/pacman-dev/2011-July/013895.html

Loading...