FS#15240 - [mkinitcpio] 0.5.25-1 breaks tuxonice resuming

Attached to Project: Arch Linux
Opened by Łukasz Fibinger (lucke) - Tuesday, 23 June 2009, 22:18 GMT
Last edited by Thomas Bächler (brain0) - Friday, 19 February 2010, 17:28 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Resuming from tuxonice hibernation using an image created by mkinitcpio 0.5.25 fails - afterwards the system boots as during a normal boot, but doesn't mount the swap partition. git snapshot from before "Use poll_device before resuming, continue if the device doesn't exist - fe2ca57793f5f8461084d69e69939d8e0bb42b2b" works a-okay.
This task depends upon

Closed by  Thomas Bächler (brain0)
Friday, 19 February 2010, 17:28 GMT
Reason for closing:  Fixed
Comment by Thomas Bächler (brain0) - Wednesday, 24 June 2009, 08:24 GMT
Here's the diff for reference: http://projects.archlinux.org/?p=mkinitcpio.git;a=commitdiff;h=fe2ca57793f5f8461084d69e69939d8e0bb42b2b

What does your commandline look like? I just remembered, it may be my fault after all, tuxonice doesn't just accept a device, but also an offset (for swap files and for the file writer), that needs to be taken into account. Otherwise, the hook will think the device does not exist and continue after a 10 second timeout. Is this the case here?
Comment by Łukasz Fibinger (lucke) - Wednesday, 24 June 2009, 15:02 GMT
Yeah, it does work without that poll_device check. The resume paramater is "resume=swap:/dev/sda7'.
Comment by Thomas Bächler (brain0) - Wednesday, 24 June 2009, 16:11 GMT
I need to rewrite this again so it takes the special syntax of tuxonice into account - I completely forgot that.
Comment by Ng Oon-Ee (ngoonee) - Sunday, 04 October 2009, 15:54 GMT
Hi, I was wondering why my tuxonice setup didn't work and was redirected here, downgrading to .24 does fix it. Just a 'me too', since there doesn't seem to have been activity here since.
Comment by Thomas Bächler (brain0) - Sunday, 10 January 2010, 17:28 GMT
There is a fix here, but due to the lack of a "cut" binary, this will not work until mkinitcpio 0.6 is finished:
http://projects.archlinux.org/mkinitcpio.git/commit/?h=kill-klibc&id=3fceb27acec3c2039639c6f9d205da24b3b68619
Comment by Łukasz Fibinger (lucke) - Sunday, 10 January 2010, 17:47 GMT
Latest tuxonice versions can resume without the resume parameter if swap partition is used (see Latest News on http://www.tuxonice.net/) - just something to consider.
Comment by Thomas Bächler (brain0) - Sunday, 07 February 2010, 20:56 GMT
The version with the fix is in testing now. I remember someone tested it and it works, but I forgot where, so please verify it.
Comment by Łukasz Fibinger (lucke) - Monday, 08 February 2010, 00:53 GMT
That grep test doesn't work, so I've put in a different one. If there's no tuxonice image, it proceeds to perform a normal resume and stat spits out trash, so I've added another test. Attached version works a-okay.
   resume (1 KiB)
Comment by Thomas Bächler (brain0) - Monday, 08 February 2010, 09:26 GMT
The grep doesn't work because it is wrong, my bad. I don't like explicitly looking for the 5th character, it is merely a coincidence that both "file" and "swap" have 4 characters. I will merge your changes this evening, slightly modified. Thanks for the feedback.
Comment by Thomas Bächler (brain0) - Monday, 08 February 2010, 09:42 GMT
How about this: http://projects.archlinux.org/mkinitcpio.git/commit/?h=kill-klibc&id=e6d8a6ed2c1884072e6323072da7f1a5333e3b73
Comment by Łukasz Fibinger (lucke) - Monday, 08 February 2010, 12:14 GMT
Your version works okay.
Comment by Thomas Bächler (brain0) - Monday, 08 February 2010, 12:23 GMT
Thank you for the review. The next version will likely be out later today.
Comment by Łukasz Fibinger (lucke) - Sunday, 14 February 2010, 17:57 GMT
I presume this bug report can be closed now.

Loading...