FS#15123 - [netsurf] looks like a Microsoft Windows package

Attached to Project: Community Packages
Opened by Greg (dolby) - Tuesday, 16 June 2009, 00:18 GMT
Last edited by Paulo Matias (thotypous) - Thursday, 18 June 2009, 18:22 GMT
Task Type Bug Report
Category
Status Closed
Assigned To Paulo Matias (thotypous)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I am sorry but thats the best title i could come up with for this "package"
See the build script yourself: http://repos.archlinux.org/viewvc.cgi/community/network/netsurf/PKGBUILD?view=markup&root=community

Its 5 packages in one.

All dependencies are part of unsupported but in their SVN versions.
libnsbmp: http://aur.archlinux.org/packages.php?ID=25163
libnsgif: http://aur.archlinux.org/packages.php?ID=25164
libparserutils: http://aur.archlinux.org/packages.php?ID=27121
hubbub: http://aur.archlinux.org/packages.php?ID=27122

I don't care how many votes packages have, but those that look like this one shouldn't make it to binary repos.
This task depends upon

Closed by  Paulo Matias (thotypous)
Thursday, 18 June 2009, 18:22 GMT
Reason for closing:  Implemented
Additional comments about closing:  Packages libnsbmp, libnsgif, libparserutils and hubbub created in community. They are makedepends of netsurf-2.1-2. Now using lemon from sqlite repository instead of the tarball.
Comment by Greg (dolby) - Tuesday, 16 June 2009, 00:19 GMT
OH! I forgot sqlite! Such a shame! Yes it includes that too. :)
Comment by Paulo Matias (thotypous) - Tuesday, 16 June 2009, 00:32 GMT
Well, those didn't exist when I made the package. And as they are only used in the netsurf package, I included they in the same package (following the "avoid to split packages" philosophy). The sqlite tarball is used to workaround a building bug. I found no other way to do that.

About adding the package, it had a good amount of votes when I upgraded the PKGBUILD, so I thought moving it to [community] would be a good idea. Not only because of votes, but because a light browser (nowadays netsurf is more used than dillo in those scenarios by what I can see) can be useful in low end machines, and because it can be useful for webdesigners to test websites in one more environment.

But I have no problem to move it back to unsupported if you fell this should not be in community. I just moved it in good intention.
Comment by Greg (dolby) - Tuesday, 16 June 2009, 00:36 GMT
Build scripts shouldnt look like that. The dependencies should be seperate packages. Period. Thats unless they can be statically built.
Its not a matter of moving it back to unsupported or not. Also i am not questioning your intentions. I am sure you meant well.
Comment by Paulo Matias (thotypous) - Tuesday, 16 June 2009, 00:45 GMT
Currently, they are statically built by this package. I just checked, and what could be a problem here is that the development files (headers, static libs, pkgconfig files) are included in the package. Do you think we should remove that?

I think it would be better to stay with only one package for netsurf if possible. I think those libs will hardly ever be used by another project. (I don't know why the netsurf developers had chosen to split their codebase like that.)
Comment by Loui Chang (louipc) - Tuesday, 16 June 2009, 00:50 GMT
I think the big problem here is the sqlite bundling.
I wouldn't really expect you to package netsurf specific libraries separately.
Comment by Paulo Matias (thotypous) - Tuesday, 16 June 2009, 00:54 GMT
Well, sqlite is not being built at all. I'm only using the lemon tool that comes in the sqlite tarball to regenerate a parser's code during the building process.

I could get only lemon directly from the sqlite repository, but I thought the tarball would be better because it can be included in the sources array and because its md5sum can be checked.
Comment by Loui Chang (louipc) - Tuesday, 16 June 2009, 01:14 GMT
You can still put it in the sources and get it directly from the sqlite repo, etc.

That'll get you the same revision every time:
http://www.sqlite.org/cvstrac/getfile?f=sqlite/tool/lemon.c&v=1.69

Prefix it with 'lemon.c::' in the sources array.
Comment by Paulo Matias (thotypous) - Tuesday, 16 June 2009, 04:12 GMT
Good idea Loui :) I will modify the PKGBUILD tomorrow to do this way.
Any issues/suggestions left?
Comment by Greg (dolby) - Tuesday, 16 June 2009, 09:50 GMT
"Currently, they are statically built by this package"

Statically built means that the netsurf source ($pkgname-$pkgver) would include all those libs and you wouldnt have to download them in order to build netsurf. Which clearly isnt the case here.

"I think those libs will hardly ever be used by another project"

That is no excuse not to build them seperately. See for example libmcs & libmowgli with audacious. Packaging in Linux works that way.

"Any issues/suggestions left?"

IMO if you arent willing to build a proper package it would be better to move it back to unsupported and suggest to the one who picks it up to make the changes himself.
But im not gonna be using this application anyway.
Comment by Paulo Matias (thotypous) - Wednesday, 17 June 2009, 00:24 GMT
Well sorry for all this arguing Greg, I really took a time to understand your point.

I will wait until tomorrow to see if anyone disagrees with splitting the packages, then split them.

I would only want to clarify that the reason for merging the packages was not only because no other packages use them currently, but because I was concerned with the problems we had last year about the *number* of packages in community growing and slowing down the community backend (that required some repository cleanup and new rules for packages entering community). I don't know how much this is a problem right now, but I just took some advice with Hugo and he said that should not be a major concern, so let's go for it if nobody has any objections.

Please tell if any issues/suggestions/concerns are left. I would prefer to do all in one go for pkgrel=2.
Comment by Greg (dolby) - Wednesday, 17 June 2009, 00:35 GMT
Arguing ( http://www.merriam-webster.com/dictionary/arguing ) tends to bring the best results most of the time. :)
Sorry for not being clear about what the issue was, but i amazed to discover a package like that .Thought the problem was obvious.

Loading...