FS#14057 - the /arch/setup doesn't complain after "Prepare Hard Drive"
Attached to Project:
Release Engineering
Opened by Maurel (guy-kde) - Wednesday, 01 April 2009, 16:32 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Sunday, 02 August 2009, 17:18 GMT
Opened by Maurel (guy-kde) - Wednesday, 01 April 2009, 16:32 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Sunday, 02 August 2009, 17:18 GMT
|
Details
Description:
with both the 2009.2-ftp-x86_64.iso and the 2009.2-core-i686.iso, it is posible NOT to finish the question about the "Prepare Hard Drive"/ "Set Filesystem Mountpoints" with the "select DONE when finished" an "OK". The setup doesn't complain about this! You may go on, choose and download and install... but THIS is wrong. The system is NOT on the disk! |
This task depends upon
The reason is that in the function mountpoints(), in the while-loop, it is possible to choose "CANCEL" instead of "DONE".
So one go out the function without making the file(s) system(s) nor mount anything.
I would like to make a little proposition to prevent this and inform the user.
The attachment contains a difference the actual /arch/setup and my proposition.
If one only choose a swap and "Cancel", one get some issues (which are OK) and the question "Do you want to (go) back and fix...".
If one choose "No" (it would be bad), one get an "Error on activating swap" and only a "OK"-button.
The next message is: "Partitions were successfully created".
Oh! What about the swap-message? and NO partition for / was choosen.
With "OK" one may return to the Main Menu.
The next step "Select Pacakages" is marked, and "nobody" complains anymore about the problem.
My proposition at /arch/setup was to make it impossible to make such an error.
The variable "ret", define at the second line, is not local. It is the same as the one in the "ask_option" function.
So the value is set, even nothing is done (such as choose "Return to Main Menu").
The next test, done as "check_depend worker prepare_disks" becomes "OK", even if something is wrong.
A proposition could be: Change the variable "ret" in the function "Worker_prepare_disk" to anything else, let say: "ret_wpd"
2) i agree that if it says "Error on activating swap" it should not say "Partitions were successfully created". so we just test this by creating nothing but a swap partition. TO TEST
3) if you are in the partition editor and you select cancel, it should not try to continue. TO TEST
4) I made the ret variable local everywhere. http://github.com/Dieterbe/aif/commit/14fc7d28f64debe5e466c94df83878243df29f9c
2) Don't know if i understood the test and the problem correct
I delete all partitions by "Manually Partion Hard Drives", only remaining the swap partition.
Then went to "Manually configure block devices..." and setup this partition as swap.
If i say: DONE afterwards i got the "Issues detected" dialog where aif complains about non-existing / and /boot partition.
Using "go back and fix it" works here, also if i say "Ignore".
With "ignore" aif creates correctly the swap partition and says: "Partitions were successfully created". And this is right IMHO.
I got no "Error on activating swap"
There may be a more nuanced swap-related bug or pebcak (maybe if you setup disks, don't rollback and then do it again, or rollback twice - see
FS#15753- or something like that).I did however fix a bug where we returned 0 even though the Fs did not create successfully. This explained that *if* swap creation failed, we got told everything was OK.
http://github.com/Dieterbe/aif/commit/634e70cf97013fbf67133962fd02468f6c32fbc5