FS#12947 - Selection jumps to step 1 (Set Clock) after step 2 (Prepare Hard Drive)
Attached to Project:
Release Engineering
Opened by Evangelos Foutras (foutrelis) - Saturday, 24 January 2009, 22:31 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Saturday, 31 January 2009, 13:31 GMT
Opened by Evangelos Foutras (foutrelis) - Saturday, 24 January 2009, 22:31 GMT
Last edited by Dieter Plaetinck (Dieter_be) - Saturday, 31 January 2009, 13:31 GMT
|
Details
I think the problem is that NEXTITEM is used for tracking
purposes inside prepare_harddrive(). However, this is used
in the top-level options list as well, so other functions
(besides mainmenu()) shouldn't change it.
Making NEXTITEM local to prepare_harddrive() seems to solve this problem. (see attached tiny patch) |
This task depends upon
Closed by Dieter Plaetinck (Dieter_be)
Saturday, 31 January 2009, 13:31 GMT
Reason for closing: Fixed
Additional comments about closing: fixed
Saturday, 31 January 2009, 13:31 GMT
Reason for closing: Fixed
Additional comments about closing: fixed
For archlinux-installer: I'm not sure the solution is *this* easy, but I don't intend to invest time to investigate/patch up archlinux-installer.
I doubt any of the archlinux-installer maintainers are interested either. I added them so we'll see...
@Aaron: if you make a new installer package to fix
FS#12944, could you apply Evangelos patch?I'll post a re-revised patch after some testing. :3
I'm sorry for posting the second patch without testing it first. Here's the corrected/tested patch that also adds selection tracking to the "FTP Installation" dialog.
That's how I did it in aif at least.
I'm no usability expert, but I believe that returning to the same item is more intuitive; you return to the exact same item you left from.
If you really believe it should advance to the next item if the previous step completed successfully (I don't, but as I've said I'm no usability expert :>), I can have a look at it.
I think it depends on what you expect. When I think of it, both your and mine way "behave like expected" depending on how the user expected it. It are just 2 different mindsets. I think some people may intuitively expect your, and others, mine behaviour.
Either way, I think my way is at least technically better, because it decreases the need to use keypresses.
Btw Evangelos, I didn't know you were an official contributor/developer/whatever. I don't think we have met.. Hi, I'm Dieter :-)
"If you really believe it should advance to the next item if the previous step completed successfully (I don't, but as I've said I'm no usability expert :>), I can have a look at it."
Don't put to much time in it.. aif will replace archlinux-installer in the future.
I'm a (relatively new) TU, but I like messing with developers' stuff when time and knowledge allows.
I'll take your advice and won't put much effort into making the installer advance on successful steps; I will give it a shot though.
(aif looks very well-built and hopefully will make our lives easier in future releases, good work!)
If anyone thinks it's still worth enough to open a new ticket for a behaviour change for archlinux-installer like discussed above, he can open a new ticket and provide a patch...