FS#12764 - Deluge should depends on libtorrent-rasterbar

Attached to Project: Arch Linux
Opened by A. K. (Misery) - Monday, 12 January 2009, 17:07 GMT
Last edited by Hugo Doria (hdoria) - Wednesday, 18 March 2009, 12:05 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Hugo Doria (hdoria)
Architecture All
Severity Low
Priority Normal
Reported Version None
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Deluge should depends on libtorrent-rasterbar package like Debian's package (http://packages.debian.org/experimental/deluge).
It will compile and link libtorrent-rasterbar by itself on every build of deluge and that package will have a copy of that library. I think it is better if it just link to libtorrent-rasterbar package instead.
This task depends upon

Closed by  Hugo Doria (hdoria)
Wednesday, 18 March 2009, 12:05 GMT
Reason for closing:  Fixed
Comment by Greg (dolby) - Sunday, 01 February 2009, 10:14 GMT
That sounds like a feature request. Deluge doesnt require the libtorrent library to run. The library is not even in extra.
Not even the upstream provided deluge.PKGBUILD has it listed as a dependency. http://download.deluge-torrent.org/arch/1.1.2/deluge-1.1.2.pkgbuild
Debian does it is not a reason for everyone else to do it
Comment by A. K. (Misery) - Sunday, 01 February 2009, 13:23 GMT
Well, deluge needs libtorrent-rasterbar! Just look into the sources...
They have it in their own source tree because big distros (like debian) didn't had a package for that. Debian has a package for libtorrent-rasterbar now - so there is no need to build the included library in deluge. ;-)

http://dev.deluge-torrent.org/browser/trunk/libtorrent
Comment by A. K. (Misery) - Sunday, 01 February 2009, 13:32 GMT
By the way... I didn't say that "debian" is a reason. ;-)
It's only a hint that it is possible to switch from internal library to system library!
Comment by A. K. (Misery) - Tuesday, 10 March 2009, 01:50 GMT
A little example:
I rebuild libtorrent-rasterbar 0.14.2 with --enable-python-binding and link deluge against it instead of building included lib.

deluge package:
Installed Size: 16143,00 K (included lib)
Installed Size: 9852.00 K (use rasterbar package)

And updating deluge is much more faster now because it only needs to byte-compile the python scripts.
Comment by Xavier (shining) - Tuesday, 10 March 2009, 13:42 GMT
Just in case there could still be some confusion, the first line of Deluge's About web page is quite clear :
http://dev.deluge-torrent.org/wiki/About
Deluge is a full-featured BitTorrent client for Linux, Unix and Windows. It uses libtorrent in it's backend and PyGTK for it's user interface.
And libtorrent links to http://www.rasterbar.com/products/libtorrent/

Though it might be problematic that deluge is maintained in extra, and libtorrent-rasterbar in community.
To make things worse, both arch packages are also out-of-date.
Comment by Xavier (shining) - Tuesday, 10 March 2009, 13:43 GMT
To Misery : it could still be helpful if you could provide patches for these two pkgbuilds, for implementing your feature request.
Comment by A. K. (Misery) - Tuesday, 10 March 2009, 17:45 GMT
Xaviar: there is no big patch needed. libtorrent-rasterbar only needs --enable-python-binding in ./configure and deluge needs libtorrent-rasterbar>=0.14.2 as depends(). The build system of deluge will detect the system lib and will use it. :-)
Comment by Xavier (shining) - Tuesday, 10 March 2009, 17:50 GMT
Ok perfect, that is simple enough, thanks for the clarification.
Comment by Hugo Doria (hdoria) - Tuesday, 10 March 2009, 17:52 GMT
I will try to move this to [extra] and update both packages (deluge and libtorrent-rasterbar).
Comment by A. K. (Misery) - Tuesday, 10 March 2009, 21:07 GMT
I saw that discussion about to rename that package to libtorrent. I don't think that it is a good idea because every other big distribution uses "-rasterbar" for this library and "libtorrent" for rakshasa.

And the library itself uses that name, too:
$ cat $srcdir/libtorrent-rasterbar.pc
[...]
package=libtorrent-rasterbar

Name: libtorrent-rasterbar
Description: Bittorrent library.
Version: 0.14.2
Libs: -L${libdir} -ltorrent-rasterbar
[...]
Comment by Hugo Doria (hdoria) - Wednesday, 18 March 2009, 12:05 GMT
Fixed on deluge 1.1.5.

Loading...