FS#10881 - URL missing from web although present in PKGBUILD

Attached to Project: Arch Linux
Opened by Greg (dolby) - Thursday, 10 July 2008, 18:13 GMT
Last edited by Dusty Phillips (Dusty) - Thursday, 21 August 2008, 20:44 GMT
Task Type Bug Report
Category Web Sites
Status Closed
Assigned To Dusty Phillips (Dusty)
Architecture All
Severity Low
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: The URL field missing when browsing some packages on archlinux.org although its present in the PKGBUILD

Spotted 2 of those until now. latex2rtf and cdparanoia

Additional info:
http://archlinux.org/pipermail/arch-general/2008-July/018218.html


Steps to reproduce:
http://archlinux.org/packages/330/
http://archlinux.org/packages/3503/
This task depends upon

Closed by  Dusty Phillips (Dusty)
Thursday, 21 August 2008, 20:44 GMT
Reason for closing:  Fixed
Additional comments about closing:  Patch applied. More Hugs for Eliott.
Comment by eliott (cactus) - Thursday, 21 August 2008, 08:14 GMT
this is likely due to the package being added at one point, and then later the url being added (like along with a version bump of the rel or something).
When a package is updated, the only fields currently updated are as follows:

pkgver, pkgrel, pkgdesc, needupdate, last_update

There was an original assumption on my part, that some fields were very seldom changed, and it wouldn't make sense from a performance standpoint to update the fields that didn't need it (since the update mechanism was written using the django orm..which is 'chatty').

It would be a trivial patch to add the URL field to the list of those updated, if it is deemed appropriate.
Comment by eliott (cactus) - Thursday, 21 August 2008, 08:26 GMT
attached patch. I optusely made the commit message descriptive, since the patch was so short.
ha!

ps. dusty...git patches composed with format-patch can be applied with 'git am'.
;)
   0001-Fix-for-FS-10881-URL-mis... (1.4 KiB)
Comment by Xavier (shining) - Thursday, 21 August 2008, 08:44 GMT
Having the url field empty looks weird.
If performance is really a problem, maybe these packages could just be fixed manually then.
Comment by Xavier (shining) - Thursday, 21 August 2008, 08:46 GMT
Ah I missed the patch, and it is simpler than I thought :) Thanks cactus!
Comment by Dusty Phillips (Dusty) - Thursday, 21 August 2008, 12:43 GMT
I don't think there will be much of a performance hit, It still all happens in a single SQL query. Adding one column to the update shouldn't hurt anybody even as many times as this code is executed (once per package per half hour or something). I'll apply the patch when I'm feeling less overworked.

Loading...