FS#10395 - Xchat not built with spell checking enabled

Attached to Project: Arch Linux
Opened by Ken S (scriptmunkee) - Monday, 12 May 2008, 06:08 GMT
Last edited by Eric Belanger (Snowman) - Saturday, 14 June 2008, 03:50 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Eric Belanger (Snowman)
Architecture All
Severity Low
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
I noticed that the version of xchat installed with Arch does not enable spell checking by default. I would like to see xchat built with spell checking enabled either by using libsexy or directly to aspell.

Additional info:
* package version(s): 2.8.4-3
* config and/or log files etc.


Steps to reproduce:
1) Install xchat
2) Start xchat
3) Try a word wrong in the xchat input line and see if the word is underscored with a red wavy line.
4) No spell checking is enabled

Also look into the PKGBUILD script and see if `--enable-spell=none` is set.
This task depends upon

Closed by  Eric Belanger (Snowman)
Saturday, 14 June 2008, 03:50 GMT
Reason for closing:  Implemented
Additional comments about closing:  xchat 2.8.6 has now spell support.
Comment by Greg (dolby) - Monday, 12 May 2008, 06:36 GMT
Can you try compiling it yourself to see if it crashes like reported in  FS#10349  ?
Comment by Ken S (scriptmunkee) - Monday, 12 May 2008, 06:40 GMT
I am now running a compiled version of 2.8.4 and all is good. I am not seeing the crash. I have version 1.4.1-2 of enchant installed. I did not use the pacman packaging system for the install and building. I have my compiled xchat binary running out of $HOME/bin.
Comment by Ken S (scriptmunkee) - Monday, 12 May 2008, 07:30 GMT
I am now running a compiled version of 2.8.4 and all is good. I am not seeing the crash. I have version 1.4.1-2 of enchant installed. I did not use the pacman packaging system for the install and building. I have my compiled xchat binary running out of $HOME/bin.
Comment by Eric Belanger (Snowman) - Saturday, 17 May 2008, 03:59 GMT
How about --enable-spell=static ? Would that be OK?

If libsexy or gtkspell are used for the spelling support, they will need to be added as a dependency. This is something I would like to avoid. Using --enable-spell=static adds spell support without adding a dependency, but I don't really know if libsexy or gtkspell are better.
Comment by Ken S (scriptmunkee) - Saturday, 17 May 2008, 16:54 GMT
I believe Eric's idea would work. It adds the dependency on the side of the package maintainer to make sure they have libsexy, enchant and/or gtkspell installed. Which shouldn't be an issue if they are running gnome on their build environment.

Here is an old post that explains the --enable-spell options. http://forum.xchat.org/viewtopic.php?t=2863&highlight=static
Comment by Eric Belanger (Snowman) - Friday, 06 June 2008, 15:28 GMT
I'm leaning toward using --enable-spell=static. It uses enchant to check the spelling so you'll need to have it installed to have spell check. I'll probably wait for an update or a bug and add spelling support at the same time.
Comment by Ken S (scriptmunkee) - Saturday, 07 June 2008, 05:20 GMT
Eric, the timing for the update sounds good. The only question I have it, would you add enchant as a dependency or add a install note that if spell checking is wanted you would need to install enchant?
Comment by Eric Belanger (Snowman) - Sunday, 08 June 2008, 20:32 GMT
enchant will not be a dependency or even a makedepends. Users will need to explicitely install enchant if they want spell support.

I don't intend to create a .install file. I'll use the newer optdepends array. The optional dependency on enchant will be displayed when doing 'pacman -Qi xchat'.

Loading...