FS#10104 - slim login manager won't build

Attached to Project: Arch Linux
Opened by Niki Kovacs (kikinovak) - Monday, 07 April 2008, 11:13 GMT
Last edited by Alexander Fehr (pizzapunk) - Friday, 12 December 2008, 01:09 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Aaron Griffin (phrakture)
Alexander Fehr (pizzapunk)
Architecture All
Severity Medium
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I just tried to build the slim login manager from ABS, in order to put my own default configurations into the package. The build process stops short, with the following error message:

/usr/bin/g++ -Wall -I. -I/usr/include/xorg -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/libpng12 -I/usr/include -DPACKAGE=\"slim\" -DVERSION=\"1.3.0\" -DPKGDATADIR=\"/usr/share/slim\" -DSYSCONFDIR=\"/etc\" -DHAVE_SHADOW -c numlock.cpp -o numlock.o
/usr/bin/g++ -Wall -I. -I/usr/include/xorg -I/usr/include/freetype2 -I/usr/include/freetype2/config -I/usr/include/libpng12 -I/usr/include -DPACKAGE=\"slim\" -DVERSION=\"1.3.0\" -DPKGDATADIR=\"/usr/share/slim\" -DSYSCONFDIR=\"/etc\" -DHAVE_SHADOW -c cfg.cpp -o cfg.o
cfg.cpp: In static member function ‘static int Cfg::string2int(const char*, bool*)’:
cfg.cpp:212: erreur: ‘strtol’ was not declared in this scope
make: *** [cfg.o] Erreur 1
==> ERREUR: La compilation a échoué.

Which leaves me clueless.
This task depends upon

Closed by  Alexander Fehr (pizzapunk)
Friday, 12 December 2008, 01:09 GMT
Reason for closing:  Fixed
Additional comments about closing:  slim 1.3.1-1
Comment by Niki Kovacs (kikinovak) - Monday, 07 April 2008, 15:45 GMT
I'm not a developer, so I can only guess. But it looks like someone found a viable solution here:

http://slackbuilds.org/slackbuilds/12.0/desktop/slim/Makefile-i686.diff.gz

Comment by Jay Bromley (jbromley) - Monday, 21 April 2008, 08:08 GMT
I tried the above patch on the original sources and it did not work. However, the attached stdlib.patch patch did correct the problem with both the original sources and the Arch package.

I put this patch in an ABS build of arch and used the attached PKGBUILD to successfully build, install, and use the package. The attached PKGBUILD.patch shows the changes I made to the PKGBUILD. I just added a patch command to apply the stdlib.patch and added MD5SUM information.

This all works, but it seems odd to me that something as basic as the location of stdlib would be in different places in the slim developers' build systems and in Arch. I took a look at the slim bug list and there were no mentions of build problems. In fact, I built slim from source a few of months ago and it worked fine.


   stdlib.patch (0.2 KiB)
   PKGBUILD (1.6 KiB)
   PKGBUILD.patch (0.8 KiB)
Comment by Greg (dolby) - Saturday, 17 May 2008, 15:19 GMT
Can you sumbit the patch upstream?
Comment by Jay Bromley (jbromley) - Sunday, 18 May 2008, 03:57 GMT
OK, I'll try that out. The last time I checked their bug tracker I saw no indication of this problem, which is odd because anyone who wanted to build it would have experienced the bug. Nonetheless, I will submit a bug and the respective patch and see what happens.
Comment by Jay Bromley (jbromley) - Sunday, 18 May 2008, 04:25 GMT
OK, in the slim project patch manager, there is already a patch (#2248) for this problem. I have asked if this patch will be applied to mainline code on the slim-dev mailing list. If they don't fix it upstream I guess we will have to do it here. What could the source of this problem be? Gcc version (4.3.0).


Comment by Jay Bromley (jbromley) - Monday, 19 May 2008, 04:42 GMT
I posted about the problem and the already existing patch to the slim-dev list. Here is the correspondence:

[snip]
> Apparently, cfg.cpp isn't including cstdlib for the strtol function. I
> see that there is patch #2248 to correct this problem and I was
> wondering if this patch will make it into mainline code. If not, why
> not? Perhaps the problem lies in version 4.3.0 of gcc? It would be
> nice to have this fixed here in mainline code. If not I will have to
> patch it downstream in the Arch package.

Thanks, I committed to the svn trunk. I plan to do a general review
of pending patches and requests and do a small maintainance release
in a couple of days.

Regards,
Simone

It seems this will be patched upstream soon, so this should solve the problem for Arch.
Comment by Roman Kyrylych (Romashka) - Sunday, 28 September 2008, 14:35 GMT
the slim package was last built on 2008-09-13, so I assume we can close this report, right?
Comment by Demios (Demios) - Monday, 20 October 2008, 20:19 GMT
Has this bug been squished yet? If so are there any other workarounds besides the one posed above?
Comment by Allan McRae (Allan) - Tuesday, 21 October 2008, 00:42 GMT
Not fixed yet but there is a new upstream release which fixes this problem.

Loading...